Skip to content

Commit 1efd52a

Browse files
authored
Fix a bug of listIndexes() (#1416)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
1 parent 08914ab commit 1efd52a

2 files changed

Lines changed: 20 additions & 6 deletions

File tree

sdk-core/src/main/java/io/milvus/v2/service/index/IndexService.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -178,11 +178,11 @@ public List<String> listIndexes(MilvusServiceGrpc.MilvusServiceBlockingStub bloc
178178
return new ArrayList<>();
179179
}
180180
rpcUtils.handleResponse(title, response.getStatus());
181-
List<String> indexNames = new ArrayList<>();
182-
response.getIndexDescriptionsList().forEach(index -> {
183-
indexNames.add(index.getIndexName());
184-
});
185-
return indexNames;
181+
182+
return response.getIndexDescriptionsList().stream()
183+
.filter(desc -> request.getFieldName() == null || desc.getFieldName().equals(request.getFieldName()))
184+
.map(IndexDescription::getIndexName)
185+
.collect(Collectors.toList());
186186
}
187187

188188
private void WaitForIndexComplete(MilvusServiceGrpc.MilvusServiceBlockingStub blockingStub,

sdk-core/src/test/java/io/milvus/v2/client/MilvusClientV2DockerTest.java

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1289,6 +1289,7 @@ void testIndex() {
12891289
extra.put("efConstruction",64);
12901290
indexes.add(IndexParam.builder()
12911291
.fieldName("vector")
1292+
.indexName("abc")
12921293
.indexType(IndexParam.IndexType.HNSW)
12931294
.metricType(IndexParam.MetricType.COSINE)
12941295
.extraParams(extra)
@@ -1358,6 +1359,19 @@ void testIndex() {
13581359
collProps = descCollResp.getProperties();
13591360
Assertions.assertFalse(collProps.containsKey("prop"));
13601361

1362+
// list indexes
1363+
List<String> names = client.listIndexes(ListIndexesReq.builder()
1364+
.collectionName(randomCollectionName)
1365+
.fieldName("vector")
1366+
.build());
1367+
Assertions.assertEquals(1, names.size());
1368+
Assertions.assertEquals("abc", names.get(0));
1369+
1370+
names = client.listIndexes(ListIndexesReq.builder()
1371+
.collectionName(randomCollectionName)
1372+
.build());
1373+
Assertions.assertEquals(2, names.size());
1374+
13611375
// describe scalar index
13621376
DescribeIndexResp descResp = client.describeIndex(DescribeIndexReq.builder()
13631377
.collectionName(randomCollectionName)
@@ -1419,7 +1433,7 @@ void testIndex() {
14191433
// drop index
14201434
client.dropIndex(DropIndexReq.builder()
14211435
.collectionName(randomCollectionName)
1422-
.indexName("vector")
1436+
.indexName("abc")
14231437
.build());
14241438

14251439
IndexParam param = IndexParam.builder()

0 commit comments

Comments
 (0)