Skip to content

Commit 40bc29e

Browse files
DivyaDivya
authored andcommitted
Addressing review comments
1 parent a7a11ab commit 40bc29e

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

sdk-core/src/main/java/io/milvus/v2/client/ConnectConfig.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ public class ConnectConfig {
4848
private String proxyAddress;
4949
private Boolean secure = false;
5050
private long idleTimeoutMs = TimeUnit.MILLISECONDS.convert(24, TimeUnit.HOURS);
51+
private boolean enablePrecheck = false; // default value is false
5152

5253
private SSLContext sslContext;
5354
// clientRequestId maintains a map for different threads, each thread can assign a specific id.

sdk-core/src/main/java/io/milvus/v2/client/MilvusClientV2.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -132,9 +132,11 @@ private void initServices(String dbName) {
132132
*/
133133
private void connect(ConnectConfig connectConfig) {
134134
this.connectConfig = connectConfig;
135-
validateHostname(connectConfig);
136-
validatePort(connectConfig);
137-
validateCert(connectConfig);
135+
if (connectConfig.isEnablePrecheck()) {
136+
validateHostname(connectConfig);
137+
validatePort(connectConfig);
138+
validateCert(connectConfig);
139+
}
138140
try {
139141
if (this.channel != null) {
140142
// close channel first
@@ -288,7 +290,7 @@ public void validatePort(ConnectConfig connectConfig) {
288290
throw new MilvusClientException(ErrorCode.RPC_ERROR, message);
289291
}
290292
}
291-
293+
292294
/**
293295
* Validates SSL connection with certificates.
294296
*

0 commit comments

Comments
 (0)