Skip to content

Commit bda9a55

Browse files
lentitude2tkclaude
andauthored
Add forcePromote to UpdateReplicateConfigurationRequest and forceDrop to DropRoleRequest (#1790)
Signed-off-by: lentitude2tk <xushuang.hu@zilliz.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 3366d28 commit bda9a55

File tree

6 files changed

+56
-0
lines changed

6 files changed

+56
-0
lines changed

sdk-core/src/main/java/io/milvus/client/AbstractMilvusGrpcClient.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2634,6 +2634,7 @@ public R<RpcStatus> dropRole(DropRoleParam requestParam) {
26342634
try {
26352635
DropRoleRequest request = DropRoleRequest.newBuilder()
26362636
.setRoleName(requestParam.getRoleName())
2637+
.setForceDrop(requestParam.isForceDrop())
26372638
.build();
26382639

26392640
Status response = blockingStub().dropRole(request);

sdk-core/src/main/java/io/milvus/param/role/DropRoleParam.java

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,14 @@
2525
public class DropRoleParam {
2626

2727
private final String roleName;
28+
private final boolean forceDrop;
2829

2930
private DropRoleParam(DropRoleParam.Builder builder) {
3031
if (builder == null) {
3132
throw new IllegalArgumentException("Builder cannot be null");
3233
}
3334
this.roleName = builder.roleName;
35+
this.forceDrop = builder.forceDrop;
3436
}
3537

3638
public static DropRoleParam.Builder newBuilder() {
@@ -41,10 +43,15 @@ public String getRoleName() {
4143
return roleName;
4244
}
4345

46+
public boolean isForceDrop() {
47+
return forceDrop;
48+
}
49+
4450
@Override
4551
public String toString() {
4652
return "DropRoleParam{" +
4753
"roleName='" + roleName + '\'' +
54+
", forceDrop=" + forceDrop +
4855
'}';
4956
}
5057

@@ -53,6 +60,7 @@ public String toString() {
5360
*/
5461
public static final class Builder {
5562
private String roleName;
63+
private boolean forceDrop;
5664

5765
private Builder() {
5866
}
@@ -71,6 +79,17 @@ public DropRoleParam.Builder withRoleName(String roleName) {
7179
return this;
7280
}
7381

82+
/**
83+
* Sets the forceDrop flag. If true, the role will be force dropped.
84+
*
85+
* @param forceDrop forceDrop
86+
* @return <code>Builder</code>
87+
*/
88+
public DropRoleParam.Builder withForceDrop(boolean forceDrop) {
89+
this.forceDrop = forceDrop;
90+
return this;
91+
}
92+
7493
/**
7594
* Verifies parameters and creates a new {@link DropRoleParam} instance.
7695
*

sdk-core/src/main/java/io/milvus/v2/service/cdc/CDCService.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ public class CDCService extends BaseService {
3030
public UpdateReplicateConfigurationResp updateReplicateConfiguration(MilvusServiceGrpc.MilvusServiceBlockingStub blockingStub, UpdateReplicateConfigurationReq requestParam) {
3131
UpdateReplicateConfigurationRequest request = UpdateReplicateConfigurationRequest.newBuilder()
3232
.setReplicateConfiguration(requestParam.getReplicateConfiguration().toGRPC())
33+
.setForcePromote(requestParam.isForcePromote())
3334
.build();
3435

3536
String title = "UpdateReplicateConfiguration";

sdk-core/src/main/java/io/milvus/v2/service/cdc/request/UpdateReplicateConfigurationReq.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,15 @@
2121

2222
public class UpdateReplicateConfigurationReq {
2323
private ReplicateConfiguration replicateConfiguration;
24+
private boolean forcePromote;
2425

2526
public static UpdateReplicateConfigurationReqBuilder builder() {
2627
return new UpdateReplicateConfigurationReqBuilder();
2728
}
2829

2930
private UpdateReplicateConfigurationReq(UpdateReplicateConfigurationReqBuilder builder) {
3031
this.replicateConfiguration = builder.replicateConfiguration;
32+
this.forcePromote = builder.forcePromote;
3133
}
3234

3335
public ReplicateConfiguration getReplicateConfiguration() {
@@ -38,21 +40,36 @@ public void setReplicateConfiguration(ReplicateConfiguration replicateConfigurat
3840
this.replicateConfiguration = replicateConfiguration;
3941
}
4042

43+
public boolean isForcePromote() {
44+
return forcePromote;
45+
}
46+
47+
public void setForcePromote(boolean forcePromote) {
48+
this.forcePromote = forcePromote;
49+
}
50+
4151
@Override
4252
public String toString() {
4353
return "UpdateReplicateConfigurationReq{" +
4454
"replicateConfiguration=" + replicateConfiguration +
55+
", forcePromote=" + forcePromote +
4556
'}';
4657
}
4758

4859
public static class UpdateReplicateConfigurationReqBuilder {
4960
private ReplicateConfiguration replicateConfiguration;
61+
private boolean forcePromote;
5062

5163
public UpdateReplicateConfigurationReqBuilder replicateConfiguration(ReplicateConfiguration replicateConfiguration) {
5264
this.replicateConfiguration = replicateConfiguration;
5365
return this;
5466
}
5567

68+
public UpdateReplicateConfigurationReqBuilder forcePromote(boolean forcePromote) {
69+
this.forcePromote = forcePromote;
70+
return this;
71+
}
72+
5673
public UpdateReplicateConfigurationReq build() {
5774
return new UpdateReplicateConfigurationReq(this);
5875
}

sdk-core/src/main/java/io/milvus/v2/service/rbac/RBACService.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ public Void dropRole(MilvusServiceGrpc.MilvusServiceBlockingStub blockingStub, D
8888
String title = String.format("Drop role: '%s'", request.getRoleName());
8989
DropRoleRequest dropRoleRequest = DropRoleRequest.newBuilder()
9090
.setRoleName(request.getRoleName())
91+
.setForceDrop(request.isForceDrop())
9192
.build();
9293
Status status = blockingStub.dropRole(dropRoleRequest);
9394
rpcUtils.handleResponse(title, status);

sdk-core/src/main/java/io/milvus/v2/service/rbac/request/DropRoleReq.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,11 @@
2121

2222
public class DropRoleReq {
2323
private String roleName;
24+
private boolean forceDrop;
2425

2526
private DropRoleReq(DropRoleReqBuilder builder) {
2627
this.roleName = builder.roleName;
28+
this.forceDrop = builder.forceDrop;
2729
}
2830

2931
public String getRoleName() {
@@ -34,10 +36,19 @@ public void setRoleName(String roleName) {
3436
this.roleName = roleName;
3537
}
3638

39+
public boolean isForceDrop() {
40+
return forceDrop;
41+
}
42+
43+
public void setForceDrop(boolean forceDrop) {
44+
this.forceDrop = forceDrop;
45+
}
46+
3747
@Override
3848
public String toString() {
3949
return "DropRoleReq{" +
4050
"roleName='" + roleName + '\'' +
51+
", forceDrop=" + forceDrop +
4152
'}';
4253
}
4354

@@ -47,6 +58,7 @@ public static DropRoleReqBuilder builder() {
4758

4859
public static class DropRoleReqBuilder {
4960
private String roleName;
61+
private boolean forceDrop;
5062

5163
private DropRoleReqBuilder() {
5264
}
@@ -56,6 +68,11 @@ public DropRoleReqBuilder roleName(String roleName) {
5668
return this;
5769
}
5870

71+
public DropRoleReqBuilder forceDrop(boolean forceDrop) {
72+
this.forceDrop = forceDrop;
73+
return this;
74+
}
75+
5976
public DropRoleReq build() {
6077
return new DropRoleReq(this);
6178
}

0 commit comments

Comments
 (0)