Skip to content

Avoid an exception of LocalBulkWriter in Java 24 env #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sre-ci-robot merged 1 commit into from
May 8, 2025
Merged

Avoid an exception of LocalBulkWriter in Java 24 env #1391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions sdk-bulkwriter/src/main/java/io/milvus/bulkwriter/common/utils/ParquetReaderUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
package io.milvus.bulkwriter.common.utils;

import org.apache.avro.generic.GenericData;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.Path;
import org.apache.parquet.avro.AvroParquetReader;

Expand All @@ -31,7 +30,7 @@ public void readParquet(String localFilePath) throws IOException {
Path path = new Path(localFilePath);
try (org.apache.parquet.hadoop.ParquetReader<GenericData.Record> reader = AvroParquetReader
.<GenericData.Record>builder(path)
.withConf(new Configuration())
.withConf(ParquetUtils.getParquetConfiguration())
.build()) {
GenericData.Record record;
while ((record = reader.read()) != null) {
Expand Down
8 changes: 8 additions & 0 deletions sdk-bulkwriter/src/main/java/io/milvus/bulkwriter/common/utils/ParquetUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

package io.milvus.bulkwriter.common.utils;

import org.apache.hadoop.conf.Configuration;
import org.apache.parquet.schema.LogicalTypeAnnotation;
import org.apache.parquet.schema.MessageType;
import org.apache.parquet.schema.PrimitiveType;
Expand Down Expand Up @@ -158,4 +159,11 @@ private static void fillArrayType(Types.MessageTypeBuilder messageTypeBuilder, C
break;
}
}

public static Configuration getParquetConfiguration() {
// set fs.file.impl.disable.cache to true for this issue: https://github.com/milvus-io/milvus-sdk-java/issues/1381
Configuration configuration = new Configuration();
configuration.set("fs.file.impl.disable.cache", "true");
return configuration;
}
}
2 changes: 1 addition & 1 deletion sdk-bulkwriter/src/main/java/io/milvus/bulkwriter/writer/ParquetFileWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ private void initWriter() throws IOException {
int rowGroupBytes = 16 * 1024 * 1024;

// declare and define the ParquetWriter.
Configuration configuration = new Configuration();
Configuration configuration = ParquetUtils.getParquetConfiguration();
GroupWriteSupport.setSchema(messageType, configuration);
GroupWriteSupport writeSupport = new GroupWriteSupport();
this.writer = new ParquetWriter<>(new Path(filePath),
Expand Down
Loading