diff --git a/sdk-core/src/main/java/io/milvus/client/MilvusClient.java b/sdk-core/src/main/java/io/milvus/client/MilvusClient.java index 5d48a3851..f53899407 100644 --- a/sdk-core/src/main/java/io/milvus/client/MilvusClient.java +++ b/sdk-core/src/main/java/io/milvus/client/MilvusClient.java @@ -45,10 +45,16 @@ import java.util.concurrent.TimeUnit; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + /** * The Milvus Client Interface */ public interface MilvusClient { + + Logger logger = LoggerFactory.getLogger(MilvusClient.class); + /** * Timeout setting for rpc call. * @@ -99,7 +105,7 @@ default void close() { try { close(TimeUnit.MINUTES.toSeconds(1)); } catch (InterruptedException e) { - System.out.println("Interrupted during shutdown Milvus client!"); + logger.error("Interrupted during shutdown Milvus client!"); } } diff --git a/sdk-core/src/main/java/io/milvus/orm/iterator/SearchIterator.java b/sdk-core/src/main/java/io/milvus/orm/iterator/SearchIterator.java index 6a14a226e..829b51a03 100644 --- a/sdk-core/src/main/java/io/milvus/orm/iterator/SearchIterator.java +++ b/sdk-core/src/main/java/io/milvus/orm/iterator/SearchIterator.java @@ -227,7 +227,6 @@ private void setUpRangeParameters(List page) { tailBand = getDistance(lastHit); String msg = String.format("set up init parameter for searchIterator width:%s tail_band:%s", width, tailBand); logger.debug(msg); -// System.out.println(msg); } private void updateFilteredIds(SearchResultsWrapper searchResultsWrapper) { diff --git a/sdk-core/src/main/java/io/milvus/v2/client/MilvusClientV2.java b/sdk-core/src/main/java/io/milvus/v2/client/MilvusClientV2.java index 6de5f1904..22d59f243 100644 --- a/sdk-core/src/main/java/io/milvus/v2/client/MilvusClientV2.java +++ b/sdk-core/src/main/java/io/milvus/v2/client/MilvusClientV2.java @@ -1044,7 +1044,7 @@ public void close() { try { close(TimeUnit.MINUTES.toSeconds(1)); } catch (InterruptedException e) { - System.out.println("Interrupted during shutdown Milvus client!"); + logger.error("Interrupted during shutdown Milvus client!"); } } diff --git a/sdk-core/src/main/java/io/milvus/v2/service/collection/CollectionService.java b/sdk-core/src/main/java/io/milvus/v2/service/collection/CollectionService.java index 23eb334f3..e31cd7fbd 100644 --- a/sdk-core/src/main/java/io/milvus/v2/service/collection/CollectionService.java +++ b/sdk-core/src/main/java/io/milvus/v2/service/collection/CollectionService.java @@ -481,7 +481,7 @@ private void WaitForLoadCollection(MilvusServiceGrpc.MilvusServiceBlockingStub b Thread.sleep(500); // Sleep for 0.5 second. Adjust this value as needed. } catch (InterruptedException e) { Thread.currentThread().interrupt(); - System.out.println("Thread was interrupted, Failed to complete operation"); + logger.error("Thread was interrupted, Failed to complete operation"); return; // or handle interruption appropriately } } diff --git a/sdk-core/src/main/java/io/milvus/v2/service/index/IndexService.java b/sdk-core/src/main/java/io/milvus/v2/service/index/IndexService.java index 32c656dae..acc8cd254 100644 --- a/sdk-core/src/main/java/io/milvus/v2/service/index/IndexService.java +++ b/sdk-core/src/main/java/io/milvus/v2/service/index/IndexService.java @@ -249,7 +249,7 @@ private void WaitForIndexComplete(MilvusServiceGrpc.MilvusServiceBlockingStub bl Thread.sleep(500); // Sleep for 0.5 second. Adjust this value as needed. } catch (InterruptedException e) { Thread.currentThread().interrupt(); - System.out.println("Thread was interrupted, failed to complete operation"); + logger.error("Thread was interrupted, failed to complete operation"); return; // or handle interruption appropriately } } diff --git a/sdk-core/src/main/java/io/milvus/v2/service/partition/PartitionService.java b/sdk-core/src/main/java/io/milvus/v2/service/partition/PartitionService.java index 5e11a3092..9d2497063 100644 --- a/sdk-core/src/main/java/io/milvus/v2/service/partition/PartitionService.java +++ b/sdk-core/src/main/java/io/milvus/v2/service/partition/PartitionService.java @@ -152,7 +152,7 @@ private void WaitForLoadPartitions(MilvusServiceGrpc.MilvusServiceBlockingStub b Thread.sleep(500); // Sleep for 0.5 second. Adjust this value as needed. } catch (InterruptedException e) { Thread.currentThread().interrupt(); - System.out.println("Thread was interrupted, failed to complete operation"); + logger.error("Thread was interrupted, failed to complete operation"); return; // or handle interruption appropriately } } diff --git a/sdk-core/src/main/java/io/milvus/v2/service/vector/VectorService.java b/sdk-core/src/main/java/io/milvus/v2/service/vector/VectorService.java index 8ae0dec46..444310975 100644 --- a/sdk-core/src/main/java/io/milvus/v2/service/vector/VectorService.java +++ b/sdk-core/src/main/java/io/milvus/v2/service/vector/VectorService.java @@ -372,7 +372,7 @@ public RunAnalyzerResp runAnalyzer(MilvusServiceGrpc.MilvusServiceBlockingStub b builder.addAllAnalyzerNames(analyzerNames); String params = JsonUtils.toJson(request.getAnalyzerParams()); - System.out.println(params); + logger.debug(params); RunAnalyzerRequest runRequest = builder.addAllPlaceholder(byteStrings) .setAnalyzerParams(params) .setWithDetail(request.getWithDetail())