Skip to content

Fix a compatible issue of RRFRanker/WeightedRanker #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sre-ci-robot merged 1 commit into from
Aug 8, 2025
Merged

Fix a compatible issue of RRFRanker/WeightedRanker #1521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions sdk-core/src/main/java/io/milvus/v2/service/vector/request/ranker/RRFRanker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,16 @@
*/
@SuperBuilder
public class RRFRanker extends CreateCollectionReq.Function {
// This constructor is to compatible with the old client code like:
// new RRFRanker(10)
// Now it is deprecated, user should create a RRFRanker by builder style:
// RRFRanker.builder().k(10).build()
@Deprecated
public RRFRanker(int k) {
super(CreateCollectionReq.Function.builder());
this.k = k;
}

@Builder.Default
private int k = 60;

Expand Down
10 changes: 10 additions & 0 deletions sdk-core/src/main/java/io/milvus/v2/service/vector/request/ranker/WeightedRanker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,16 @@
*/
@SuperBuilder
public class WeightedRanker extends CreateCollectionReq.Function {
// This constructor is to compatible with the old client code like:
// new WeightedRanker(weights)
// Now it is deprecated, user should create a WeightedRanker by builder style:
// WeightedRanker.builder().weights(weights).build()
@Deprecated
public WeightedRanker(List<Float> weights) {
super(CreateCollectionReq.Function.builder());
this.weights = weights;
}

@Builder.Default
private List<Float> weights = new ArrayList<>();

Expand Down
Loading