second step: remove lombok at io.milvus.v2#1527
Closed
yeyinglang wants to merge 0 commit intomilvus-io:master_remove_lombokfrom
yeyinglang:master_remove_lombok
Closed
second step: remove lombok at io.milvus.v2#1527yeyinglang wants to merge 0 commit intomilvus-io:master_remove_lombokfrom yeyinglang:master_remove_lombok
yeyinglang wants to merge 0 commit intomilvus-io:master_remove_lombokfrom
yeyinglang:master_remove_lombok
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yeyinglang The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
second step: remove lombok at io.milvus.v2
tips: compatible with the previous version
Remove Lombok will be implemented in 5 steps
Remove Lombok at one package which function has not yet been widely popularized (eg:io.milvus.v2.service.resourcegroup )
Remove Lombok at onepackage which functions have been popularized
Remove Lombok at large package (eg io.milvus.v2.service)
Remove Lombok at Milvus V2 Package (io.milvus.v2)
Remove Lombok at all src places (io.milvus)
Test Case Results