Delete equals() and hashCode() methods, rename Builder, reformat code#1654
Merged
sre-ci-robot merged 1 commit intomilvus-io:masterfrom Oct 29, 2025
Merged
Delete equals() and hashCode() methods, rename Builder, reformat code#1654sre-ci-robot merged 1 commit intomilvus-io:masterfrom
sre-ci-robot merged 1 commit intomilvus-io:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yhmo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yhmo
force-pushed
the
ma
branch
3 times, most recently
from
bb1b62a to
1dca659
Compare
yhmo
changed the title
yhmo
force-pushed
the
ma
branch
3 times, most recently
from
7368bf1 to
98a0c89
Compare
yhmo
force-pushed
the
ma
branch
5 times, most recently
from
c76e3c9 to
60608c9
Compare
Signed-off-by: yhmo <yihua.mo@zilliz.com>
yhmo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason we renamed the Bilder class name from "Builder" to "XXXBuilder" is: the lombok
@Builderand@SuperBuildergenerate Builder class with name "XXXBuilder", user might explicitly declare a build like this:To ensure compatibility, we rename Builder class name to "XXXBuilder"
#1651