Adding Exception handling for MilvusClient V2

[divyaruhil]

Currently, milvus-java-sdk returns generic DEADLINE_EXCEEDED error for all connection-related issues (invalid host, wrong port, or certificate errors).
This makes it difficult to identify the root cause .
DEADLINE_EXCEEDED: CallOptions deadline exceeded after 7.780172042s. Name resolution delay 2.199438000 seconds. [closed=[], open=[[wait_for_ready, buffered_nanos=7788263209, waiting_for_connection]]]

As per our discussion, there’s no direct way to unwrap specific exceptions for MilvusClientV2.

This PR introduces enhanced exception handling to validate and provide clearer error messages for invalid hostname, port, and certificate issues in MilvusClientV2.

Fix for issue

[sre-ci-robot]

Welcome @divyaruhil! It looks like this is your first PR to milvus-io/milvus-sdk-java 🎉

[yhmo]

@divyaruhil
Thank you for your pr. I have one concern: it might break some users' online business if the pre-check methods can not handle all cases. Can we add a flag to the ConnectConfig to enable/disable the pre-check process? I would prefer to set its default value to "false".

public class ConnectConfig {
  private boolean enablePrecheck = false;  // default value is false
  ......
}

public class MilvusClientV2 {
    private void connect(ConnectConfig connectConfig) {
        this.connectConfig = connectConfig;
        if (connectConfig.isEnablePrecheck()) {
            validateHostname(connectConfig);
            validatePort(connectConfig);
            validateCert(connectConfig);
        }
        ......

[divyaruhil]

Hi @yhmo , thankyou for reviewing, i have made the required changes.

[yhmo]

Hi @divyaruhil
Still have 5 comments about the error code and timeout values.

[divyaruhil]

Hi @yhmo , can u pls point me out what error code and timeout values you are referring to ? I am only able to see one review comment which is this one #1671 (comment).

[yhmo]

You can switch to the "Files changed" page, the comments are in the right panel:

[divyaruhil]

Hi @yhmo,

Thanks for sharing the screenshot! It seems there might be a small glitch — I’m unable to view your review comments on my side.

@yhmo
I have a doubt from one of your review comments regarding whether socket.connect() can handle a proxy address. I’m not entirely clear on that part. Can you please help me understand the proxy address part ?
Other than that i have addressed other review comments.

[yhmo]

Hi @yhmo,

Thanks for sharing the screenshot! It seems there might be a small glitch — I’m unable to view your review comments on my side. @yhmo I have a doubt from one of your review comments regarding whether socket.connect() can handle a proxy address. I’m not entirely clear on that part. Can you please help me understand the proxy address part ? Other than that i have addressed other review comments.

The ConnectConfig class has a member named "proxyAddress", user can assign a proxy address as a string. The proxyAddress is passed into the ManagedChannelBuilder by the configureProxy() method, when user wants to connect the milvus server via a proxy server.

milvus-sdk-java/sdk-core/src/main/java/io/milvus/v2/utils/ClientUtils.java

Line 202 in 7d65f05

public ProxiedSocketAddress proxyFor(SocketAddress targetServerAddress) {

When user has a proxy server, the connection between the client and milvus server might be unreachable.

[divyaruhil]

Thanks @yhmo for the clarification. I wanted to share that I've actually tested the current implementation with proxyAddress configurations, and it's working correctly with all the validation methods.

As per my knowledge , Proxy configuration is managed at the HTTP/gRPC client layer, not at the individual socket connection level.

When a proxy is configured, the actual TCP connection establishes with the proxy server, which then forwards traffic to the final destination .

My current validation methods (validateHostname, validatePort, validateCert) are specifically designed to verify the final Milvus server destination.

[yhmo]

Thanks @yhmo for the clarification. I wanted to share that I've actually tested the current implementation with proxyAddress configurations, and it's working correctly with all the validation methods.

As per my knowledge , Proxy configuration is managed at the HTTP/gRPC client layer, not at the individual socket connection level.

When a proxy is configured, the actual TCP connection establishes with the proxy server, which then forwards traffic to the final destination .

My current validation methods (validateHostname, validatePort, validateCert) are specifically designed to verify the final Milvus server destination.

Ok, sounds good. I will merge this pr into the source code and cherry-pick it to the 2.6 branch. Thank you!

[yhmo]

/lgtm
/approve

[sre-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyaruhil, yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [yhmo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment