Adding Exception handling for MilvusClient V2 (#1671)#1674
Merged
sre-ci-robot merged 1 commit intomilvus-io:2.6from Nov 13, 2025
Merged
Adding Exception handling for MilvusClient V2 (#1671)#1674sre-ci-robot merged 1 commit intomilvus-io:2.6from
sre-ci-robot merged 1 commit intomilvus-io:2.6from
Conversation
* Adding Exception handling for validating hostname, port and cert in MilvusClientV2 Signed-off-by: Divya <DIVYA2@ibm.com> * Addressing review comments Signed-off-by: Divya <DIVYA2@ibm.com> * formatting correction Signed-off-by: Divya <DIVYA2@ibm.com> * Addressing review comments Signed-off-by: Divya <DIVYA2@ibm.com> * fixing compilation error Signed-off-by: Divya <DIVYA2@ibm.com> * Corrected validateCert implementation Signed-off-by: Divya <DIVYA2@ibm.com> --------- Signed-off-by: Divya <DIVYA2@ibm.com> Co-authored-by: Divya <DIVYA2@ibm.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yhmo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Exception handling for validating hostname, port and cert in MilvusClientV2
Addressing review comments
formatting correction
Addressing review comments
fixing compilation error
Corrected validateCert implementation