Skip to content

Allow to insert pk even when auto-id is true, milvus v2.6.3 supports #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sre-ci-robot merged 1 commit into from
Dec 8, 2025
Merged

Allow to insert pk even when auto-id is true, milvus v2.6.3 supports #1712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions sdk-core/src/main/java/io/milvus/v2/utils/DataUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,10 +273,12 @@ private void processNormalFieldValues(JsonObject row, CreateCollectionReq.FieldS
}

// from v2.4.10, milvus allows upsert for auto-id pk, no need to check for upsert action
if (field.getAutoID() == Boolean.TRUE && insertBuilder != null) {
String msg = String.format("The primary key: %s is auto generated, no need to input.", fieldName);
throw new MilvusClientException(ErrorCode.INVALID_PARAMS, msg);
}
// from v2.6.3, user can insert pk value even when auto-id is true if the collection
// has "allow_insert_auto_id" property, no need to check for insert/upsert action.
// if (field.getAutoID() == Boolean.TRUE && insertBuilder != null) {
// String msg = String.format("The primary key: %s is auto generated, no need to input.", fieldName);
// throw new MilvusClientException(ErrorCode.INVALID_PARAMS, msg);
// }

// store the value into InsertDataInfo
Object fieldValue = DataUtils.checkFieldValue(field, fieldData);
Expand Down
Loading