Support search by id

[yhmo]

No description provided.

[sre-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [yhmo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello @yhmo, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the search capabilities by introducing support for querying data directly using primary keys (IDs). This allows users to retrieve specific entities without needing to provide vector embeddings. The core changes involve extending the SearchReq object to accommodate ID lists and refactoring the internal utility logic to correctly process either vector-based or ID-based search requests, ensuring mutual exclusivity. The development environment's Milvus version has also been updated, and a new test case confirms the proper functioning of the ID search feature.

Highlights

• Search by ID Capability: Introduced the ability to perform search operations using a list of primary keys (IDs) in addition to vector-based search, enhancing query flexibility.
• Search Request Structure Update: The SearchReq class was modified to include a new ids field, along with corresponding builder methods and toString() representation.
• Search Target Handling Logic: A new utility method convertSearchTarget was added to VectorUtils to intelligently process search requests, ensuring that either vectors or IDs are provided, but not both or neither.
• Milvus Version Upgrade: The Milvus Docker image version used in docker-compose.yml and TestUtils.java was updated from v2.6.7 to v2.6.9.
• New Test Case for ID Search: A dedicated test case was added to MilvusClientV2DockerTest to validate the functionality of searching by IDs.
• Temporary Debugging Statement: A System.out.println(request); statement was temporarily added to the search method in MilvusClientV2.java, likely for debugging purposes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces support for searching by ID, which is a valuable addition. The implementation is well-structured, with the core logic encapsulated in the new convertSearchTarget method. The changes are accompanied by relevant test cases. I've identified a leftover debug statement that should be removed and a minor opportunity for code improvement for better clarity.