Support search by id

[yhmo]

No description provided.

[sre-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [yhmo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello @yhmo, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Milvus Java SDK by introducing the capability to search for entities directly by their primary key IDs. This provides greater flexibility for users who need to retrieve specific data points without providing vector embeddings. The changes involve modifying the search request structure, implementing robust logic to handle both ID and vector-based searches, and updating the development environment to a newer Milvus version. A new test case ensures the reliability of this added functionality.

Highlights

• ID-based Search Capability: Introduced the ability to perform vector searches using a list of primary key IDs, providing an alternative to vector-based searches.
• Search Request Enhancement: The SearchReq class now includes an ids field, along with corresponding builder methods and toString() updates, to accommodate ID-based search requests.
• Search Target Conversion Logic: Refactored the VectorUtils to include a new convertSearchTarget method, which intelligently handles whether the search is performed using vectors or IDs, ensuring that only one method is used per request.
• Milvus Version Upgrade: Updated the Milvus Docker image version from v2.6.7 to v2.6.9 in docker-compose.yml and TestUtils.java, ensuring compatibility and leveraging the latest features.
• New Test Case for ID Search: Added a dedicated test case in MilvusClientV2DockerTest.java to validate the functionality of searching by IDs.
• Debugging Statement: A System.out.println(request); debugging statement was added to the search method in MilvusClientV2.java. This should be removed before merging to production.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for searching by ID, which is a valuable feature. The implementation looks solid, with appropriate changes to the request objects and conversion logic. I've identified a critical issue with a leftover debug print statement that needs to be removed. Additionally, I have a couple of medium-severity suggestions to enhance type safety and error handling, which would improve the SDK's robustness and developer experience. The accompanying tests for the new functionality are well-implemented.