Skip to content

Support highlighter#1746

Merged
sre-ci-robot merged 1 commit intomilvus-io:2.6from
yhmo:26
Jan 20, 2026
Merged

Support highlighter#1746
sre-ci-robot merged 1 commit intomilvus-io:2.6from
yhmo:26

Conversation

@yhmo
Copy link
Copy Markdown
Contributor

@yhmo yhmo commented Jan 20, 2026

No description provided.

Signed-off-by: yhmo <yihua.mo@zilliz.com>
@sre-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @yhmo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Milvus Java SDK by introducing robust support for search result highlighting. It provides a flexible framework for users to define and apply various highlighting strategies, both lexical and semantic, directly within their search requests. The changes ensure that the SDK can effectively communicate these preferences to the Milvus server and accurately parse the enriched search responses, ultimately improving the clarity and utility of search results for end-users.

Highlights

  • New Highlighter Interface and Implementations: Introduced a new Highlighter interface along with two concrete implementations: LexicalHighlighter for keyword-based highlighting and SemanticHighlighter for context-aware highlighting. These allow users to specify how search results should be visually emphasized.
  • Integration with Search Request: The SearchReq object has been extended to include a Highlighter field, enabling users to configure highlighting options directly within their search queries. This includes a builder pattern for easy construction of highlighter settings.
  • Enriched Search Response: The SearchResp.SearchResult class now includes a highlightResults map, which stores detailed HighlightResult objects for each field. A new HighlightResult inner class has been added to encapsulate highlighted fragments and their scores.
  • Internal Utility Enhancements: Modified SearchResultsWrapper to expose Position and getOffsetByIndex for external use, facilitating the processing of highlight data. ConvertUtils and VectorUtils were updated to handle the serialization of highlighter configurations for gRPC requests and the deserialization of highlight results from gRPC responses.
  • Protocol Buffer Update: The underlying Milvus protocol definitions have been updated to support the new highlighter functionality, indicated by a subproject commit change.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mergify mergify Bot added the dco-passed label Jan 20, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for search result highlighting by adding a Highlighter interface with LexicalHighlighter and SemanticHighlighter implementations. The changes span across request building, gRPC conversion, and response parsing to accommodate this new feature. The implementation is comprehensive, but I've identified a critical runtime bug in the gRPC type conversion that needs to be addressed, along with a minor maintainability improvement to remove redundant code.

Comment thread sdk-core/src/main/java/io/milvus/v2/utils/VectorUtils.java
@mergify mergify Bot added the ci-passed label Jan 20, 2026
@yhmo yhmo added the lgtm label Jan 20, 2026
@sre-ci-robot sre-ci-robot merged commit 9b03425 into milvus-io:2.6 Jan 20, 2026
5 checks passed
@yhmo yhmo deleted the 26 branch January 20, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants