Skip to content

add testcase for search by id, struct array ,partial uspert#1749

Merged
yhmo merged 1 commit intomilvus-io:masterfrom
yongpengli-z:lyp-0128
Jan 29, 2026
Merged

add testcase for search by id, struct array ,partial uspert#1749
yhmo merged 1 commit intomilvus-io:masterfrom
yongpengli-z:lyp-0128

Conversation

@yongpengli-z
Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @yongpengli-z, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the test suite by introducing comprehensive test cases for struct array fields, search operations using primary keys, and partial upsert functionality. These additions ensure the robustness and correctness of these advanced features within the Milvus test framework, covering various scenarios from basic operations to error handling and boundary conditions.

Highlights

  • New Test Cases for Struct Arrays: A new test file StructArrayTest.java has been added to comprehensively cover the functionality of struct arrays, including collection creation with nested vector fields, data insertion, index creation on struct vector fields, and performing search and query operations.
  • Support for Search by Primary Key: The SearchTest.java file has been updated to include new test cases for searching by primary key (both Int64 and VarChar types) instead of query vectors. This covers various scenarios such as basic search, search with filters, range search, grouping, and pagination.
  • Partial Upsert Functionality: The UpsertTest.java file now includes extensive test cases for partial updates, allowing specific fields of existing entities to be updated without overwriting the entire entity. This functionality is tested across scalar fields, vector fields, JSON fields, and dynamic fields.
  • Common Functionality Enhancements: CommonData.java and CommonFunction.java have been updated to support the new struct array and varchar primary key functionalities, including new constants for struct fields and helper methods for creating struct collections, generating struct data, and creating struct vector indexes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a significant number of new test cases for several key features: search by ID, struct arrays, and partial upserts. The changes are extensive and well-structured, particularly the new StructArrayTest.java which provides thorough coverage. I've identified a couple of areas for improvement in the helper functions for code conciseness and adherence to best practices. Overall, this is a great contribution that enhances the test suite's coverage of important functionality.

Signed-off-by: yongpengli-z <yongpeng.li@zilliz.com>
@yhmo
Copy link
Copy Markdown
Contributor

yhmo commented Jan 29, 2026

/lgtm
/approve

@sre-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yhmo, yongpengli-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yhmo yhmo merged commit 7a48d2c into milvus-io:master Jan 29, 2026
5 checks passed
yongpengli-z added a commit to yongpengli-z/milvus-sdk-java that referenced this pull request Jan 30, 2026
Signed-off-by: yongpengli-z <yongpeng.li@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Feb 4, 2026
Signed-off-by: yongpengli-z <yongpeng.li@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants