Skip to content

Add index type AISAQ#1752

Merged
sre-ci-robot merged 4 commits intomilvus-io:2.6from
chocoboxxf:feat/2.6-add-index-type-aisaq
Feb 4, 2026
Merged

Add index type AISAQ#1752
sre-ci-robot merged 4 commits intomilvus-io:2.6from
chocoboxxf:feat/2.6-add-index-type-aisaq

Conversation

@chocoboxxf
Copy link
Copy Markdown
Contributor

related: #1750

  1. Add index type AISAQ
  2. Update doc

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @chocoboxxf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request expands the Milvus SDK's capabilities by adding a new index type, AISAQ, to the IndexParam.IndexType enum. Concurrently, the associated documentation has been updated to reflect this new addition and to include several other existing index types, ensuring comprehensive and up-to-date information for users.

Highlights

  • New Index Type Added: The AISAQ index type has been introduced to the IndexParam.IndexType enum in the SDK core.
  • Documentation Update: The HTML documentation for IndexParam.IndexType has been updated to include AISAQ, IVF_RABITQ, MINHASH_LSH, NGRAM, and RTREE index types, ensuring the documentation reflects the available indexing options.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the new index type AISAQ to the IndexParam.IndexType enum and updates the corresponding Javadoc documentation. The code change for adding the enum is correct. The Javadoc update also includes other previously missing index types, which is a good improvement. However, the Javadoc is still not fully synchronized with the source code, as some index types are still missing. I've added a specific comment regarding this. Additionally, no tests were added for the new AISAQ index type. It would be beneficial to add a test case to IndexTest.java to verify the functionality and prevent future regressions.

Comment thread doc/io/milvus/v2/common/IndexParam.IndexType.html
xuxiaofeng added 2 commits January 29, 2026 21:11
Signed-off-by: xuxiaofeng <xuxiaofeng.work@bytedance.com>
Signed-off-by: xuxiaofeng <xuxiaofeng.work@bytedance.com>
@chocoboxxf chocoboxxf force-pushed the feat/2.6-add-index-type-aisaq branch from 7369084 to 6f5837a Compare January 29, 2026 13:11
@mergify mergify Bot added dco-passed and removed needs-dco labels Jan 29, 2026
Signed-off-by: xuxiaofeng <xuxiaofeng.work@bytedance.com>
@mergify mergify Bot added the ci-passed label Feb 4, 2026
@yhmo
Copy link
Copy Markdown
Contributor

yhmo commented Feb 4, 2026

/lgtm
/approve

@sre-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chocoboxxf, yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2f4f5d1 into milvus-io:2.6 Feb 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants