cherry-pick: add test cases for search by id and struct array. (#1749)#1753
cherry-pick: add test cases for search by id and struct array. (#1749)#1753sre-ci-robot merged 1 commit intomilvus-io:2.6from
Conversation
Signed-off-by: yongpengli-z <yongpeng.li@zilliz.com>
Summary of ChangesHello @yongpengli-z, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces significant enhancements to the Milvus V2 Java client's test suite, focusing on advanced data modeling and manipulation capabilities. It provides robust validation for the new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a comprehensive set of test cases for new features, including search by ID (for both Int64 and Varchar primary keys) and operations on struct arrays containing vectors. It also introduces tests for the partial update functionality of the upsert operation. The new tests are well-structured, covering a wide range of scenarios including positive, negative, and boundary cases, which significantly improves the test coverage for these features. My review includes a few suggestions to enhance code quality, performance in test helper methods, and the robustness of exception testing.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yhmo, yongpengli-z The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.