Skip to content

Support element filter search for struct field#1754

Merged
sre-ci-robot merged 1 commit intomilvus-io:masterfrom
yhmo:mm
Feb 9, 2026
Merged

Support element filter search for struct field#1754
sre-ci-robot merged 1 commit intomilvus-io:masterfrom
yhmo:mm

Conversation

@yhmo
Copy link
Copy Markdown
Contributor

@yhmo yhmo commented Feb 6, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 6, 2026 10:13
@sre-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for element-level filtering in struct field searches by propagating an elementLevel flag through the search pipeline and exposing element offset information in search results.

Changes:

  • Added elementLevel parameter to placeholder conversion methods to support element-level search filtering
  • Extended SearchResult to include elementOffset field for tracking matched element positions
  • Modified search request conversion to detect element_filter in query strings and set the appropriate flag

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
sdk-core/src/main/milvus-proto Updated subproject commit reference to include element-level search support
sdk-core/src/main/java/io/milvus/v2/utils/VectorUtils.java Added elementLevel parameter propagation through search request conversion methods
sdk-core/src/main/java/io/milvus/v2/utils/ConvertUtils.java Added logic to extract and set element offset from search results
sdk-core/src/main/java/io/milvus/v2/service/vector/response/SearchResp.java Added elementOffset field to SearchResult class with getter/setter and builder support
sdk-core/src/main/java/io/milvus/param/ParamUtils.java Added overloaded convertPlaceholder method with elementLevel parameter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sdk-core/src/main/java/io/milvus/v2/utils/VectorUtils.java
Comment thread sdk-core/src/main/java/io/milvus/v2/utils/ConvertUtils.java Outdated
@mergify mergify Bot added the ci-passed label Feb 6, 2026
Signed-off-by: yhmo <yihua.mo@zilliz.com>
@yhmo yhmo added the lgtm label Feb 9, 2026
@sre-ci-robot sre-ci-robot merged commit b8f2b41 into milvus-io:master Feb 9, 2026
5 checks passed
@yhmo yhmo deleted the mm branch March 19, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants