Update gRPC keepalive defaults to 10s/5s with keepalive without calls#1758
Conversation
haorenfsa
force-pushed
the
grpc-keepalive-defaults
branch
from
4a4d6ba to
4d20db9
Compare
There was a problem hiding this comment.
Pull request overview
Updates the SDK’s gRPC keepalive default configuration (V1 ConnectParam and V2 ConnectConfig) to more aggressive settings and adds unit tests to lock in the new defaults.
Changes:
- Updated default keepalive time/timeout to 10s / 5s (from 55s / 20s) in both V1 and V2 connection configs.
- Enabled
keepAliveWithoutCallsby default for both V1 and V2. - Added unit tests asserting the new default values for both APIs.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk-core/src/main/java/io/milvus/v2/client/ConnectConfig.java | Adjusts V2 connection keepalive defaults (time/timeout/without-calls). |
| sdk-core/src/main/java/io/milvus/param/ConnectParam.java | Adjusts V1 connection keepalive defaults (time/timeout/without-calls). |
| sdk-core/src/test/java/io/milvus/v2/client/MilvusClientV2Test.java | Adds a unit test asserting the new V2 defaults. |
| sdk-core/src/test/java/io/milvus/client/MilvusServiceClientTest.java | Adds a unit test asserting the new V1 defaults. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…thout calls Change keepAliveTimeMs from 55s to 10s, keepAliveTimeoutMs from 20s to 5s, and enable keepAliveWithoutCalls by default in both ConnectParam (V1) and ConnectConfig (V2). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: haorenfsa <haorenfsa@gmail.com>
haorenfsa
force-pushed
the
grpc-keepalive-defaults
branch
from
4d20db9 to
603624d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haorenfsa, yhmo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…thout calls (milvus-io#1758) Change keepAliveTimeMs from 55s to 10s, keepAliveTimeoutMs from 20s to 5s, and enable keepAliveWithoutCalls by default in both ConnectParam (V1) and ConnectConfig (V2). Signed-off-by: haorenfsa <haorenfsa@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…thout calls (#1758) (#1759) Change keepAliveTimeMs from 55s to 10s, keepAliveTimeoutMs from 20s to 5s, and enable keepAliveWithoutCalls by default in both ConnectParam (V1) and ConnectConfig (V2). Signed-off-by: haorenfsa <haorenfsa@gmail.com> Co-authored-by: shaoyue <haorenfsa@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Summary
keepAliveTimeMsdefault from 55s to 10skeepAliveTimeoutMsdefault from 20s to 5skeepAliveWithoutCallsby default (true instead of false)ConnectParam) and V2 (ConnectConfig)Test plan
MilvusServiceClientTest#connectParamDefaultsverifies V1 defaultsMilvusClientV2Test#connectConfigDefaultsverifies V2 defaultsconnectParamtest continues to pass (custom values override defaults)🤖 Generated with Claude Code