Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions sdk-core/src/main/java/io/milvus/param/ConnectParam.java
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,9 @@ public static class Builder {
private String uri;
private String token;
private long connectTimeoutMs = 10000;
private long keepAliveTimeMs = 55000;
private long keepAliveTimeoutMs = 20000;
private boolean keepAliveWithoutCalls = false;
private long keepAliveTimeMs = 10000;
private long keepAliveTimeoutMs = 5000;
private boolean keepAliveWithoutCalls = true;
Comment thread
haorenfsa marked this conversation as resolved.
private long rpcDeadlineMs = 0; // Disabling deadline

private String clientKeyPath;
Expand Down Expand Up @@ -396,7 +396,7 @@ public Builder withConnectTimeout(long connectTimeout, TimeUnit timeUnit) {

/**
* Sets the keep-alive time value of client channel. The keep-alive value must be greater than zero.
* Default is 55000 ms.
* Default is 10000 ms.
*
* @param keepAliveTime keep-alive value
* @param timeUnit keep-alive unit
Expand All @@ -412,7 +412,7 @@ public Builder withKeepAliveTime(long keepAliveTime, TimeUnit timeUnit) {

/**
* Sets the keep-alive timeout value of client channel. The timeout value must be greater than zero.
* Default value is 20000 ms
* Default value is 5000 ms
*
* @param keepAliveTimeout timeout value
* @param timeUnit timeout unit
Expand Down
12 changes: 6 additions & 6 deletions sdk-core/src/main/java/io/milvus/v2/client/ConnectConfig.java
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ public class ConnectConfig {
private String password;
private String dbName;
private long connectTimeoutMs = 10000;
private long keepAliveTimeMs = 55000;
private long keepAliveTimeoutMs = 20000;
private boolean keepAliveWithoutCalls = false;
private long keepAliveTimeMs = 10000;
private long keepAliveTimeoutMs = 5000;
private boolean keepAliveWithoutCalls = true;
private long rpcDeadlineMs = 0; // Disabling deadline

private String clientKeyPath;
Expand Down Expand Up @@ -324,9 +324,9 @@ public static class ConnectConfigBuilder {
private String password;
private String dbName;
private long connectTimeoutMs = 10000;
private long keepAliveTimeMs = 55000;
private long keepAliveTimeoutMs = 20000;
private boolean keepAliveWithoutCalls = false;
private long keepAliveTimeMs = 10000;
private long keepAliveTimeoutMs = 5000;
private boolean keepAliveWithoutCalls = true;
private long rpcDeadlineMs = 0;
private String clientKeyPath;
private String clientPemPath;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,17 @@ void connectParam() {
);
}

@Test
void connectParamDefaults() {
ConnectParam connectParam = ConnectParam.newBuilder()
.withHost("dummyHost")
.withPort(19530)
.build();
assertEquals(10000, connectParam.getKeepAliveTimeMs());
assertEquals(5000, connectParam.getKeepAliveTimeoutMs());
assertTrue(connectParam.isKeepAliveWithoutCalls());
}

@Test
void testConnect() {
ConnectParam connectParam = ConnectParam.newBuilder()
Expand Down
10 changes: 10 additions & 0 deletions sdk-core/src/test/java/io/milvus/v2/client/MilvusClientV2Test.java
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,16 @@ private static void VerifyClass(String clsName, CheckConfig config) {
checkGetAndSet(cls, config);
}

@Test
void connectConfigDefaults() {
ConnectConfig config = ConnectConfig.builder()
.uri("http://dummyHost:19530")
.build();
Assertions.assertEquals(10000, config.getKeepAliveTimeMs());
Assertions.assertEquals(5000, config.getKeepAliveTimeoutMs());
Assertions.assertTrue(config.isKeepAliveWithoutCalls());
}

@Test
void testV2BuilderClasses() {
CheckConfig config = new CheckConfig();
Expand Down
Loading