Support optimize() interface#1788
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yhmo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
Adds a new optimize() interface to the Java SDK v2 utility layer, providing an end-to-end “optimize collection” workflow (wait for indexes → compact with optional target size → wait for compaction/index rebuild → refresh load) plus supporting request/response models, task/progress tracking, and examples/tests.
Changes:
- Introduces
OptimizeReq,OptimizeResp, and an asynchronousOptimizeTaskwith progress/cancellation support. - Extends
compact()to pass an optionaltargetSize(MB) down to the server compaction request. - Adds an
OptimizeExampleand unit tests fortargetSizeparsing.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk-core/src/test/java/io/milvus/v2/service/utility/OptimizeTaskTest.java | Adds unit tests for OptimizeTask.parseTargetSize() parsing/validation. |
| sdk-core/src/main/java/io/milvus/v2/service/utility/response/OptimizeResp.java | New response DTO for optimize results and progress history. |
| sdk-core/src/main/java/io/milvus/v2/service/utility/request/OptimizeReq.java | New request DTO to configure optimize (target size, async, timeout). |
| sdk-core/src/main/java/io/milvus/v2/service/utility/request/CompactReq.java | Adds targetSize (MB) to compaction request model. |
| sdk-core/src/main/java/io/milvus/v2/service/utility/UtilityService.java | Wires targetSize into ManualCompactionRequest. |
| sdk-core/src/main/java/io/milvus/v2/service/utility/OptimizeTask.java | Implements background task execution, cancellation, waiting, and size parsing. |
| sdk-core/src/main/java/io/milvus/v2/client/MilvusClientV2.java | Adds optimize() API and implements the optimize workflow. |
| examples/src/main/java/io/milvus/v2/OptimizeExample.java | New runnable example demonstrating optimize usage. |
| examples/src/main/java/io/milvus/v2/HybridSearchExample.java | Comments out functionScore usage (currently introduces a compile issue). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b97434d to
0034e93
Compare
Signed-off-by: yhmo <yihua.mo@zilliz.com>
No description provided.