Skip to content

Add file resource interfaces#1802

Merged
sre-ci-robot merged 1 commit intomilvus-io:masterfrom
yhmo:ma
Apr 14, 2026
Merged

Add file resource interfaces#1802
sre-ci-robot merged 1 commit intomilvus-io:masterfrom
yhmo:ma

Conversation

@yhmo
Copy link
Copy Markdown
Contributor

@yhmo yhmo commented Apr 14, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 14, 2026 04:41
@sre-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Milvus “file resource” support to the Java v2 SDK utility layer by introducing request/response DTOs, wiring new RPC calls through UtilityService and MilvusClientV2, and extending the existing unit-test stubs and tests to cover the new APIs.

Changes:

  • Add new utility request/response models for file resources (AddFileResourceReq, RemoveFileResourceReq, ListFileResourcesReq, ListFileResourcesResp, FileResourceInfo).
  • Implement addFileResource, removeFileResource, and listFileResources in UtilityService and expose them in MilvusClientV2.
  • Extend mock stubbing in BaseTest and add corresponding tests in UtilityTest.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
sdk-core/src/test/java/io/milvus/v2/service/utility/UtilityTest.java Adds tests for add/remove/list file resource APIs.
sdk-core/src/test/java/io/milvus/v2/BaseTest.java Adds Mockito stubs for the new file resource RPCs.
sdk-core/src/main/java/io/milvus/v2/service/utility/response/ListFileResourcesResp.java New response wrapper for listing file resources.
sdk-core/src/main/java/io/milvus/v2/service/utility/response/FileResourceInfo.java New SDK-side model for file resource info.
sdk-core/src/main/java/io/milvus/v2/service/utility/request/RemoveFileResourceReq.java New request model for removing a file resource.
sdk-core/src/main/java/io/milvus/v2/service/utility/request/ListFileResourcesReq.java New request model for listing file resources.
sdk-core/src/main/java/io/milvus/v2/service/utility/request/AddFileResourceReq.java New request model for adding a file resource.
sdk-core/src/main/java/io/milvus/v2/service/utility/UtilityService.java Adds RPC implementations for add/remove/list file resources.
sdk-core/src/main/java/io/milvus/v2/client/MilvusClientV2.java Exposes new file resource APIs on the public client.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sdk-core/src/main/java/io/milvus/v2/client/MilvusClientV2.java Outdated
Comment thread sdk-core/src/main/java/io/milvus/v2/client/MilvusClientV2.java Outdated
@mergify mergify Bot added the ci-passed label Apr 14, 2026
Signed-off-by: yhmo <yihua.mo@zilliz.com>
@yhmo yhmo added the lgtm label Apr 14, 2026
@sre-ci-robot sre-ci-robot merged commit b6d229b into milvus-io:master Apr 14, 2026
6 checks passed
@yhmo yhmo deleted the ma branch April 14, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants