Skip to content

fix: upgrade thrift to 0.23.0#560

Merged
shanghaikid merged 1 commit into
mainfrom
fix/upgrade-thrift-0-23-0
May 7, 2026
Merged

fix: upgrade thrift to 0.23.0#560
shanghaikid merged 1 commit into
mainfrom
fix/upgrade-thrift-0-23-0

Conversation

@shanghaikid
Copy link
Copy Markdown
Contributor

@shanghaikid shanghaikid commented May 7, 2026

related: https://github.com/milvus-io/milvus-sdk-node/security/dependabot/248

Summary

  • Add a Yarn resolution to force thrift to ^0.23.0
  • Update yarn.lock so @dsnp/parquetjs resolves to thrift@0.23.0
  • Pin thrift's transitive uuid dependency to 11.1.0 to avoid Jest parsing ESM-only uuid@13 in the CommonJS test setup

Test plan

  • yarn build
  • yarn build-test

@sre-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shanghaikid

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: ryjiang <jiangruiyi@gmail.com>
@shanghaikid shanghaikid force-pushed the fix/upgrade-thrift-0-23-0 branch from 49e6fc5 to c8e1b4f Compare May 7, 2026 03:59
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.50%. Comparing base (1a8bd51) to head (c8e1b4f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #560   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files          61       61           
  Lines        4922     4922           
  Branches     1389     1389           
=======================================
  Hits         4799     4799           
  Misses        123      123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shanghaikid shanghaikid merged commit 9cda554 into main May 7, 2026
4 of 5 checks passed
@shanghaikid shanghaikid deleted the fix/upgrade-thrift-0-23-0 branch May 7, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants