Skip to content

fix: forward compact advanced params#561

Merged
shanghaikid merged 1 commit into
mainfrom
fix/compact-advanced-params
May 7, 2026
Merged

fix: forward compact advanced params#561
shanghaikid merged 1 commit into
mainfrom
fix/compact-advanced-params

Conversation

@shanghaikid
Copy link
Copy Markdown
Contributor

@shanghaikid shanghaikid commented May 7, 2026

Summary

  • Forward advanced compact options to the ManualCompaction RPC payload
  • Keep timeout out of the RPC payload while preserving it as the call deadline
  • Add unit coverage for request forwarding and gRPC e2e coverage for target_size reaching Milvus

Test plan

  • NODE_ENV=dev npx jest test/utils/Compaction.spec.ts --runInBand
  • NODE_ENV=dev npx jest test/grpc/Compaction.spec.ts --runInBand
  • npm run build

@sre-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shanghaikid

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: ryjiang <jiangruiyi@gmail.com>
@shanghaikid shanghaikid force-pushed the fix/compact-advanced-params branch from d529981 to 8076c9a Compare May 7, 2026 05:53
@sre-ci-robot sre-ci-robot added size/L and removed size/M labels May 7, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.50%. Comparing base (9cda554) to head (8076c9a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #561   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files          61       61           
  Lines        4922     4928    +6     
  Branches     1389     1391    +2     
=======================================
+ Hits         4799     4805    +6     
  Misses        123      123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shanghaikid shanghaikid merged commit c49358e into main May 7, 2026
4 of 6 checks passed
@shanghaikid shanghaikid deleted the fix/compact-advanced-params branch May 7, 2026 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants