Skip to content

fix: use secure parquetjs fork#572

Merged
shanghaikid merged 1 commit into
2.6from
fix/2.6-parquet-fork
Jun 1, 2026
Merged

fix: use secure parquetjs fork#572
shanghaikid merged 1 commit into
2.6from
fix/2.6-parquet-fork

Conversation

@shanghaikid

Copy link
Copy Markdown
Contributor

What\n- Replace the @dsnp/parquetjs runtime dependency with an npm alias to @shanghaikid/parquetjs@1.8.8\n- Keep the SDK import surface unchanged while pulling thrift@0.23.0 instead of vulnerable thrift@0.21.0\n\n## Verification\n- npm run build\n- NODE_ENV=dev npx jest test/bulkwriter/ParquetFormatter.spec.ts\n- yarn why thrift -> thrift@0.23.0\n- yarn audit --groups dependencies --level high -> 0 vulnerabilities\n- packed SDK tarball install + npm audit --omit=dev --audit-level=high -> 0 vulnerabilities

@sre-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shanghaikid

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: shanghaikid <jiangruiyi@gmail.com>
@shanghaikid
shanghaikid force-pushed the fix/2.6-parquet-fork branch from 5072386 to 37738a4 Compare June 1, 2026 13:30
@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.27%. Comparing base (fa0f3c7) to head (37738a4).

Additional details and impacted files
@@            Coverage Diff             @@
##              2.6     #572      +/-   ##
==========================================
- Coverage   97.29%   97.27%   -0.03%     
==========================================
  Files          60       60              
  Lines        4620     4620              
  Branches     1309     1309              
==========================================
- Hits         4495     4494       -1     
- Misses        120      121       +1     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shanghaikid
shanghaikid merged commit a359e87 into 2.6 Jun 1, 2026
3 of 5 checks passed
@shanghaikid
shanghaikid deleted the fix/2.6-parquet-fork branch June 1, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants