Skip to content

Add function field schema wrapper#578

Merged
shanghaikid merged 1 commit into
mainfrom
feat/add-function-field-wrapper
Jun 10, 2026
Merged

Add function field schema wrapper#578
shanghaikid merged 1 commit into
mainfrom
feat/add-function-field-wrapper

Conversation

@shanghaikid

Copy link
Copy Markdown
Contributor

Summary

  • add alterCollectionSchema wrapper for Milvus 3.0-beta function field schema changes
  • add addFunctionField convenience wrapper with BM25 sparse output validation
  • add e2e coverage for success paths, string enum input, and validation failures

Tests

  • NODE_ENV=dev npx jest test/grpc/FullTextSearch.spec.ts --runInBand
  • NODE_ENV=dev npx jest test/grpc/FullTextSearch.spec.ts --runInBand --coverage --collectCoverageFrom=milvus/grpc/Collection.ts --collectCoverageFrom=milvus/types/Collection.ts --collectCoverageFrom=milvus/const/error.ts --coverageReporters=json --coverageReporters=json-summary --coverageReporters=text
  • changed statements: 28/28 = 100.00%
  • changed branches: 17/17 = 100.00%
  • npm run build

@sre-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shanghaikid

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.54%. Comparing base (85c757f) to head (888cfb0).
⚠️ Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
+ Coverage   97.27%   97.54%   +0.27%     
==========================================
  Files          60       63       +3     
  Lines        4620     5060     +440     
  Branches     1309     1492     +183     
==========================================
+ Hits         4494     4936     +442     
- Misses        121      124       +3     
+ Partials        5        0       -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shanghaikid
shanghaikid merged commit eedaf98 into main Jun 10, 2026
3 of 5 checks passed
@shanghaikid
shanghaikid deleted the feat/add-function-field-wrapper branch June 10, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants