Skip to content

Add file resource wrappers#579

Merged
shanghaikid merged 1 commit into
mainfrom
feat/file-resource-wrapper
Jun 10, 2026
Merged

Add file resource wrappers#579
shanghaikid merged 1 commit into
mainfrom
feat/file-resource-wrapper

Conversation

@shanghaikid

Copy link
Copy Markdown
Contributor

Summary

  • add gRPC wrappers for AddFileResource, RemoveFileResource, and ListFileResources
  • add TypeScript request/response types for file resource APIs
  • add FileResource e2e coverage for list, missing object failure, and add/list/remove lifecycle

Tests

  • NODE_ENV=dev npx jest test/grpc/FileResource.spec.ts --runInBand
  • NODE_ENV=dev npx jest test/grpc/FileResource.spec.ts --runInBand --coverage --collectCoverageFrom=milvus/grpc/GrpcClient.ts --collectCoverageFrom=milvus/types/Client.ts --coverageReporters=json --coverageReporters=json-summary --coverageReporters=text
  • changed statements: 3/3 = 100.00%
  • changed branches: 7/7 = 100.00%
  • npm run build
  • git diff --check

@sre-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shanghaikid

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.55%. Comparing base (eedaf98) to head (4c28122).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #579   +/-   ##
=======================================
  Coverage   97.54%   97.55%           
=======================================
  Files          63       63           
  Lines        5060     5069    +9     
  Branches     1492     1496    +4     
=======================================
+ Hits         4936     4945    +9     
  Misses        119      119           
  Partials        5        5           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shanghaikid
shanghaikid merged commit e90f2c1 into main Jun 10, 2026
4 of 6 checks passed
@shanghaikid
shanghaikid deleted the feat/file-resource-wrapper branch June 10, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants