Skip to content

enhance: add request timeout to access logs#50004

Open
aoiasd wants to merge 1 commit into
milvus-io:masterfrom
aoiasd:feat/request-timeout-log-metric
Open

enhance: add request timeout to access logs#50004
aoiasd wants to merge 1 commit into
milvus-io:masterfrom
aoiasd:feat/request-timeout-log-metric

Conversation

@aoiasd
Copy link
Copy Markdown
Contributor

@aoiasd aoiasd commented May 22, 2026

pr: https://github.com/zilliztech/milvus-cloud-plugin/pull/254

Summary

Add request timeout fields for gRPC and REST access logs, including default formatter output and focused coverage for the new metric.

@sre-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aoiasd
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested review from bigsheeper and czs007 May 22, 2026 06:59
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label May 22, 2026
@mergify mergify Bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 22, 2026
@sre-ci-robot
Copy link
Copy Markdown
Contributor

[ci-v2-notice]
Notice: New ci-v2 system is enabled for this PR.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-build-all // for ci-v2/build-all (multi-arch builds)
  • /ci-rerun-buildenv // for ci-v2/build-env (build milvus-env builder images)
  • /ci-rerun-ut-integration // for ci-v2/ut-integration, will rerun ci-v2/build
  • /ci-rerun-ut-go // for ci-v2/ut-go, will rerun ci-v2/build
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp, will rerun ci-v2/build
  • /ci-rerun-e2e-default // for ci-v2/e2e-default
  • /ci-rerun-e2e-amd // for ci-v2/e2e-amd (e2e pool dispatcher)
  • /ci-rerun-build-ut-cov // for ci-v2/build-ut-cov (build + unit tests in one pipeline)
  • /ci-rerun-gosdk // for ci-v2/go-sdk (Go SDK E2E tests, ARM)

If you have any questions or requests, please contact @zhikunyao.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 22, 2026

@aoiasd Please associate the related issue to the body of your Pull Request. (eg. "issue: #")

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
@aoiasd aoiasd force-pushed the feat/request-timeout-log-metric branch from f9c80bf to 7e5e76c Compare May 22, 2026 07:05
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels May 22, 2026
@sre-ci-robot
Copy link
Copy Markdown
Contributor

✅ CI Loop Results f9c80bf

Stage Result Duration Tests
✅ Build SUCCESS 13.2min -
✅ Code-Check SUCCESS 7.1min -
✅ UT-GO SUCCESS 23.4min 1012 passed
✅ UT-Integration SUCCESS 24.4min 46 passed
✅ UT-CPP-Cov SUCCESS 52.6min 7725 passed

Total: 72min | Pipeline | Artifacts

Overall Coverage: 70.6%
Diff Coverage: Go 64.9% (24 hit, 13 miss, 37 measurable lines)
Total Patch Coverage: 64.9% (24/37 measurable lines)

@sre-ci-robot
Copy link
Copy Markdown
Contributor

✅ CI Loop Results 7e5e76c

Stage Result Duration Tests
✅ Build SUCCESS 14.2min -
✅ Code-Check SUCCESS 6.6min -
✅ UT-GO SUCCESS 23.5min 1012 passed
✅ UT-Integration SUCCESS 24.9min 46 passed
✅ UT-CPP-Cov SUCCESS 56.6min 7725 passed

Total: 74min | Pipeline | Artifacts

Overall Coverage: 68.6%
Diff Coverage: Go 70.6% (24 hit, 10 miss, 34 measurable lines)
Total Patch Coverage: 70.6% (24/34 measurable lines)

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.49%. Comparing base (3851df6) to head (7e5e76c).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/accesslog/info/grpc_info.go 57.14% 4 Missing and 2 partials ⚠️
internal/proxy/accesslog/info/restful_info.go 90.90% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #50004       +/-   ##
===========================================
- Coverage   84.54%   78.49%    -6.05%     
===========================================
  Files         668     2216     +1548     
  Lines      113722   384107   +270385     
===========================================
+ Hits        96145   301522   +205377     
- Misses      17525    73397    +55872     
- Partials       52     9188     +9136     
Components Coverage Δ
Client 80.59% <ø> (∅)
Core 85.29% <ø> (ø)
Go 76.48% <75.00%> (∅)
Files with missing lines Coverage Δ
...distributed/proxy/httpserver/timeout_middleware.go 70.07% <100.00%> (ø)
internal/proxy/accesslog/info/info.go 92.64% <100.00%> (ø)
internal/proxy/accesslog/info/restful_info.go 68.92% <90.90%> (ø)
internal/proxy/accesslog/info/grpc_info.go 86.41% <57.14%> (ø)

... and 1544 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sre-ci-robot sre-ci-robot added the low-code-coverage add test-label from zhikun, diff coverage > 80% label May 22, 2026
@mergify mergify Bot added the ci-passed label May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-passed dco-passed DCO check passed. do-not-merge/missing-related-issue kind/enhancement Issues or changes related to enhancement low-code-coverage add test-label from zhikun, diff coverage > 80% size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants