enhance: add request timeout to access logs#50004
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aoiasd The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
|
@aoiasd Please associate the related issue to the body of your Pull Request. (eg. "issue: #") |
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
f9c80bf to
7e5e76c
Compare
✅ CI Loop Results
|
| Stage | Result | Duration | Tests |
|---|---|---|---|
| ✅ Build | SUCCESS | 13.2min | - |
| ✅ Code-Check | SUCCESS | 7.1min | - |
| ✅ UT-GO | SUCCESS | 23.4min | 1012 passed |
| ✅ UT-Integration | SUCCESS | 24.4min | 46 passed |
| ✅ UT-CPP-Cov | SUCCESS | 52.6min | 7725 passed |
Total: 72min | Pipeline | Artifacts
Overall Coverage: 70.6%
Diff Coverage: Go 64.9% (24 hit, 13 miss, 37 measurable lines)
Total Patch Coverage: 64.9% (24/37 measurable lines)
✅ CI Loop Results
|
| Stage | Result | Duration | Tests |
|---|---|---|---|
| ✅ Build | SUCCESS | 14.2min | - |
| ✅ Code-Check | SUCCESS | 6.6min | - |
| ✅ UT-GO | SUCCESS | 23.5min | 1012 passed |
| ✅ UT-Integration | SUCCESS | 24.9min | 46 passed |
| ✅ UT-CPP-Cov | SUCCESS | 56.6min | 7725 passed |
Total: 74min | Pipeline | Artifacts
Overall Coverage: 68.6%
Diff Coverage: Go 70.6% (24 hit, 10 miss, 34 measurable lines)
Total Patch Coverage: 70.6% (24/34 measurable lines)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #50004 +/- ##
===========================================
- Coverage 84.54% 78.49% -6.05%
===========================================
Files 668 2216 +1548
Lines 113722 384107 +270385
===========================================
+ Hits 96145 301522 +205377
- Misses 17525 73397 +55872
- Partials 52 9188 +9136
🚀 New features to boost your workflow:
|
pr: https://github.com/zilliztech/milvus-cloud-plugin/pull/254
Summary
Add request timeout fields for gRPC and REST access logs, including default formatter output and focused coverage for the new metric.