Skip to content

Refactor stratum server leak handling#3876

Open
syntaxjak wants to merge 1 commit into
mimblewimble:stagingfrom
syntaxjak:fix-stratum-leaks
Open

Refactor stratum server leak handling#3876
syntaxjak wants to merge 1 commit into
mimblewimble:stagingfrom
syntaxjak:fix-stratum-leaks

Conversation

@syntaxjak

Copy link
Copy Markdown

Addressing issue: #3867

-Reworked the stratum connection handling into a single ‘handle_connection’ loop using ‘tokio::select!’ To drive reads and writes on the same ‘Frames’ socket.

  • Added an RAII ‘WorkerCleanup’ guard so workers are always removed and connections are closed even on errors.
  • Simplified the accept loop (no async_stream) and now logs peer addresses when workers connect.

@wiesche89 wiesche89 changed the base branch from master to staging June 20, 2026 07:35
@ardocrat ardocrat self-assigned this Jun 20, 2026
@iho

iho commented Jul 9, 2026

Copy link
Copy Markdown

Heads-up: #3889 also targets #3867 with the same structural approach (handle_connection + Drop guard + simpler accept loop).

That PR additionally adds idle timeout, max workers, and bounded write queues for the half-open / reconnect-storm failure mode. Worth coordinating so the two don’t land overlapping refactors without combining the resource bounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants