fix: rebroadcast txs recovered from reorg cache#3900
Open
iho wants to merge 1 commit into
Open
Conversation
After a reorg we re-applied cached transactions to the local mempool but never announced them to peers, so recovered txs could remain private to the node. Call tx_accepted for each successfully re-accepted entry so the network learns about them again. Closes mimblewimble#3489
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On reorg, the reorg cache correctly re-adds previously seen txs to the local mempool, but it never rebroadcast them. Peers that did not keep those txs (or never saw them) would not learn about them until someone else re-announced.
As noted on #3489 by @antiochp: every tx successfully re-accepted from the reorg cache should also be treated as new and rebroadcast.
Closes #3489
Changes
reconcile_reorg_cache: calladapter.tx_acceptedafter a successfuladd_to_txpoolRetention period remains configurable via
reorg_cache_period(default 30 minutes). This PR focuses on the missing rebroadcast path rather than changing the default window.Test plan
cargo test -p grin_pool --test reorg_cache_rebroadcast