fix: bound MerkleProof path length on deserialize#3902
Open
iho wants to merge 1 commit into
Open
Conversation
MerkleProof::read trusted path_len from the peer/API and called Vec::with_capacity without a cap, so a huge path_len could panic with capacity overflow or force a large allocation. Reject path lengths above 64 (well beyond any legitimate O(log n) proof) and cap preallocation. Also apply the same 100k single-read limit to StreamingReader that BinReader already enforces. Related to segment decode bounds (mimblewimble#3827 / mimblewimble#3850).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MerkleProof::readused the untrustedpath_lendirectly inVec::with_capacity. A crafted proof with a huge path length could panic (capacity overflow) or attempt a massive allocation — the same class of issue fixed for PMMR segments in #3850 / reported in #3827.Changes
TooLargeReadErrfor oversizedpath_lenbefore allocatingStreamingReader::read_fixed_byteswith BinReader’s existing 100k single-read limitu64::MAXpath lengthsTest plan
cargo test -p grin_core --test merkle_proofcargo test -p grin_core --test segment