fix: wait for send buffer space on p2p request responses#3903
Open
iho wants to merge 1 commit into
Open
Conversation
Outbound peer messages use a bounded channel with try_send that drops when full. That is fine for broadcasts, but silently dropping a GetTransaction/GetBlock response leaves the peer without data and can stall large-tx propagation after kernel-hash advertise. Use a short blocking wait for Consumed::Response, log type/size on drop/timeout, and keep try_send for unsolicited traffic. Closes mimblewimble#3392
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Large txs were accepted to the local pool and advertised by kernel hash, peers issued
GetTransaction, but full-tx responses could be silently dropped when the outbound peer send channel was full (try_send+ drop).That matches the #3392 symptoms: 8 peers request the full tx after the kernel hash, then the large tx never completes propagation.
Changes
try_sendfor unsolicited traffic (broadcasts, stems, etc.)ConnHandle::send_responsethat waits up to 5s for queue space before droppingsend_responseforConsumed::Response(answers to GetTransaction / GetBlock / etc.)send, wait-for-space forsend_responseCloses #3392
Test plan
cargo test -p grin_p2p --lib conn::tests