review changes

Author: PedroAraoz

examples/15-simple-dynamic-call/src/function.ts

@@ -31,13 +31,14 @@ export default function main(): void {
     .addTokenInFromTokenAmount(amountIn)
     .addTokenOutFromTokenAmount(minAmountOut, smartAccount)
 
-  /*
-    Dynamic call operation (called after the swap, using the received tokens)
-    It is calling the contract of tokenOut.address on the transfer() function
-    Using a literal address value for the first arg and the swap operation output as the second arg
-    This would be equivalent of doing:
-    `IERC20(tokenOut.address).transfer(to=recipient, value=result of swap)`
-  */
+  /**
+   * Dynamic call operation (executed after the swap using the received tokens).
+   * Calls the `transfer()` function on the `tokenOut.address` contract.
+   * Uses a literal address as the first argument and the swap output as the second.
+   *
+   * This is equivalent to:
+   * `IERC20(tokenOut.address).transfer(to = recipient, value = swapResult)`
+   */
   const target = tokenOut.address
   const selector = Bytes.fromHexString('0xa9059cbb') // transfer() selector
   const dynamicCall = EvmDynamicCallBuilder.forChain(chainId)

examples/15-simple-dynamic-call/tests/function.spec.ts

@@ -1,5 +1,11 @@
-import { Chains, EvmDynamicCallOperation, OpType, randomEvmAddress, SwapOperation } from '@mimicprotocol/sdk'
-import { EvmCallQueryMock, runFunction, TokenPriceQueryMock } from '@mimicprotocol/test-ts'
+import { Chains, OpType, randomEvmAddress } from '@mimicprotocol/sdk'
+import {
+  EvmCallQueryMock,
+  EvmDynamicCallOperation,
+  runFunction,
+  SwapOperation,
+  TokenPriceQueryMock,
+} from '@mimicprotocol/test-ts'
 import { expect } from 'chai'
 
 describe('Function', () => {
@@ -54,7 +60,6 @@ describe('Function', () => {
     expect(result.intents).to.have.lengthOf(1)
     const intent = result.intents[0]
 
-    expect(intent.feePayer).to.be.equal(context.user)
     expect(intent.feePayer).to.be.equal(context.user)
     expect(intent.maxFees).to.have.lengthOf(1)
     expect(intent.maxFees[0].token).to.be.equal('0x0000000000000000000000000000000000000348')

yarn.lock

@@ -1522,7 +1522,7 @@ doctrine@^2.1.0:
   dependencies:
     esutils "^2.0.2"
 
-dotenv@^17.0.0, dotenv@^17.2.3:
+dotenv@^17.0.0:
   version "17.4.2"
   resolved "https://registry.yarnpkg.com/dotenv/-/dotenv-17.4.2.tgz#c07e54a746e11eba021dd9e1047ced5afdc1c034"
   integrity sha512-nI4U3TottKAcAD9LLud4Cb7b2QztQMUEfHbvhTH09bqXTxnSie8WnjPALV/WMCrJZ6UV/qHJ6L03OqO3LcdYZw==