MOBILE-164: Collapse duplicate ISO-8601 formatter into the MindboxLogger primitive

Author: Vailence

Mindbox.xcodeproj/project.pbxproj

@@ -464,7 +464,6 @@
 		D2F7E24C2BADC4CA00B24BB8 /* MockSessionManager.swift in Sources */ = {isa = PBXBuildFile; fileRef = D2F7E24B2BADC4CA00B24BB8 /* MockSessionManager.swift */; };
 		DEC482157E5249DBBFAEFC9A /* FeatureTogglesModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9778038796A8426ABDED1E97 /* FeatureTogglesModel.swift */; };
 		EA395B77BB16CEFE6DC91D1D /* TransparentViewSyncOperationResponseTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4B7DAFAB687945FA908DB1AC /* TransparentViewSyncOperationResponseTests.swift */; };
-		F26DFF81C3FF57C3DE68DEDC /* Date+Extensions.swift in Sources */ = {isa = PBXBuildFile; fileRef = 326423031CA9C6BF0E62BEFD /* Date+Extensions.swift */; };
 		F30005442CFF3F7D004BE915 /* ABTestStubs.swift in Sources */ = {isa = PBXBuildFile; fileRef = F30005432CFF3F7D004BE915 /* ABTestStubs.swift */; };
 		F306291A2BD27D7500EF6609 /* InappFrequencyTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = F30629192BD27D7500EF6609 /* InappFrequencyTests.swift */; };
 		F30654BB2F1A83520058808C /* MindboxWebViewFacade.swift in Sources */ = {isa = PBXBuildFile; fileRef = F30654BA2F1A83520058808C /* MindboxWebViewFacade.swift */; };
@@ -766,7 +765,6 @@
 		31ED2DF025C4456600301FAD /* TestConfig_Invalid_1.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = TestConfig_Invalid_1.plist; sourceTree = "<group>"; };
 		31ED2DF125C4456600301FAD /* TestConfig_Invalid_3.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = TestConfig_Invalid_3.plist; sourceTree = "<group>"; };
 		31ED2DF925C4459400301FAD /* TestConfig_Invalid_4.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = TestConfig_Invalid_4.plist; sourceTree = "<group>"; };
-		326423031CA9C6BF0E62BEFD /* Date+Extensions.swift */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = sourcecode.swift; path = "Date+Extensions.swift"; sourceTree = "<group>"; };
 		33072F2D2664C24F001F1AB2 /* AreaResponse.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AreaResponse.swift; sourceTree = "<group>"; };
 		33072F2F2664C2E4001F1AB2 /* SubscriptionResponse.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SubscriptionResponse.swift; sourceTree = "<group>"; };
 		33072F312664C357001F1AB2 /* ProductListResponse.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ProductListResponse.swift; sourceTree = "<group>"; };
@@ -3576,7 +3574,6 @@
 				BB4D7CC62BDEC51D008E3AB8 /* Notification+Extensions.swift */,
 				BB65630F2BE3BA430090C473 /* UIApplication+Extensions.swift */,
 				F31DB4072F56A50E00DCEB85 /* NSError+Extensions.swift */,
-				326423031CA9C6BF0E62BEFD /* Date+Extensions.swift */,
 				F3482F292A65DCFC002A41EC /* String+Extensions.swift */,
 			);
 			path = Extensions;
@@ -4660,7 +4657,6 @@
 				B3A625502689F8B600B6A3B7 /* BenefitResponse.swift in Sources */,
 				84C65E6425D4FBBB008996FA /* MobileApplicationInfoUpdated.swift in Sources */,
 				84DEE8AD25CC036A00C98CC7 /* MBDatabaseRepository.swift in Sources */,
-				F26DFF81C3FF57C3DE68DEDC /* Date+Extensions.swift in Sources */,
 				6182078DDFC681D168546DAD /* HapticService.swift in Sources */,
 				A1B2C3D4E5F6A7B8C9D0E1F2 /* MotionService.swift in Sources */,
 				6182078DDFC681D168546DAE /* HapticRequest.swift in Sources */,

Mindbox/Extensions/Date+Extensions.swift

@@ -8,6 +8,7 @@
 
 import UIKit
 import WebKit
+import MindboxLogger
 
 private enum PayloadKey {
     static let sdkVersion = "sdkVersion"
@@ -238,7 +239,7 @@ extension MindboxWebViewFacade {
         ]
 
         if let firstInitDate = persistenceStorage.firstInitializationDateTime {
-            params[PayloadKey.firstInitializationDateTime] = firstInitDate.iso8601
+            params[PayloadKey.firstInitializationDateTime] = firstInitDate.toString(withFormat: .utc)
         }
 
         return params

Mindbox/InAppMessages/Presentation/Views/WebView/Debug/MindboxWebViewFacade.swift

@@ -28,7 +28,8 @@ public final class DateTime: MBDate {
     }
 
     override func decodeWithFormat(_ rawString: String) -> Date? {
-        return Date.fromISO8601(rawString)
+        return rawString.toDate(withFormat: .utc)
+            ?? rawString.toDate(withFormat: .utcWithMillis)
     }
 }
 

Mindbox/Model/Common/MBDate.swift

@@ -9,6 +9,7 @@
 import XCTest
 import UIKit
 @testable import Mindbox
+@testable import MindboxLogger
 
 final class InappShowFailureManagerTests: XCTestCase {
     private var databaseRepository: InappShowFailureDatabaseRepositoryMock!
@@ -65,7 +66,7 @@ final class InappShowFailureManagerTests: XCTestCase {
         let event = try XCTUnwrap(databaseRepository.createdEvents.first)
         let failure = try XCTUnwrap(decodeFailures(from: event)?.first)
         XCTAssertFalse(failure.dateTimeUtc.isEmpty)
-        XCTAssertNotNil(makeUTCFormatter().date(from: failure.dateTimeUtc))
+        XCTAssertNotNil(failure.dateTimeUtc.toDate(withFormat: .utc))
     }
 
     func testAddFailure_duplicateInappId_isIgnored() throws {
@@ -359,14 +360,6 @@ private extension InappShowFailureManagerTests {
         BodyDecoder<InAppShowFailuresBody>(decodable: event.body)?.body.failures
     }
 
-    func makeUTCFormatter() -> DateFormatter {
-        let formatter = DateFormatter()
-        formatter.locale = Locale(identifier: "en_US_POSIX")
-        formatter.timeZone = TimeZone(secondsFromGMT: 0)
-        formatter.dateFormat = "yyyy-MM-dd'T'HH:mm:ss'Z'"
-        return formatter
-    }
-    
     func applyFeatureToggle(shouldSendInAppShowError: Bool) {
         let settingsJSON = """
         {