Skip to content

Commit 982226f

Browse files
committed
fix
1 parent b950981 commit 982226f

2 files changed

Lines changed: 35 additions & 1 deletion

File tree

src/ClientOptions/PollingOptions.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public function setMaxRetries(int $maxRetries): self
8787
$this->maxRetries = 80;
8888
error_log("Notice: setting the amount of retries for auto-parsing to 80.");
8989
} else {
90-
$this->delaySec = $maxRetries;
90+
$this->maxRetries = $maxRetries;
9191
}
9292
return $this;
9393
}
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
<?php
2+
3+
namespace ClientOptions;
4+
5+
use Mindee\ClientOptions\PollingOptions;
6+
use PHPUnit\Framework\TestCase;
7+
8+
class PollingOptionsTest extends TestCase
9+
{
10+
public function testConstructorNoArguments(): void
11+
{
12+
$pollingOptions = new PollingOptions();
13+
self::assertEquals(80, $pollingOptions->maxRetries);
14+
self::assertEquals(1.5, $pollingOptions->delaySec);
15+
self::assertEquals(2, $pollingOptions->initialDelaySec);
16+
}
17+
18+
public function testConstructorSomeArguments(): void
19+
{
20+
$pollingOptions = new PollingOptions(maxRetries: 100);
21+
self::assertEquals(100, $pollingOptions->maxRetries);
22+
self::assertEquals(1.5, $pollingOptions->delaySec);
23+
self::assertEquals(2, $pollingOptions->initialDelaySec);
24+
}
25+
26+
public function testConstructorAllArguments(): void
27+
{
28+
// voluntarily passing arguments in a different order than the constructor
29+
$pollingOptions = new PollingOptions(delaySec: 3.0, maxRetries: 100, initialDelaySec: 10);
30+
self::assertEquals(100, $pollingOptions->maxRetries);
31+
self::assertEquals(3, $pollingOptions->delaySec);
32+
self::assertEquals(10.0, $pollingOptions->initialDelaySec);
33+
}
34+
}

0 commit comments

Comments
 (0)