update

hamishfagg · hamishfagg · commit 03683c1f9e09 · 2025-09-15T16:26:20.000+12:00
diff --git a/.github/workflows/build_deploy_dev.yml b/.github/workflows/build_deploy_dev.yml
@@ -126,6 +126,7 @@ jobs:
       deploy-env: ${{ matrix.deploy-env }}
     secrets: inherit
 
+  # This is a collection point for all of the matrix tests above so we can have a single required job
   tests_completed:
     name: All Tests Succeeded
     needs: [run_unit_tests, run_integration_tests, changes]
diff --git a/.github/workflows/build_deploy_prod.yml b/.github/workflows/build_deploy_prod.yml
@@ -45,10 +45,9 @@ jobs:
       - name: Setup uv
         uses: astral-sh/setup-uv@v5
         with:
-          # Place cache in the tool dir because we mount this in our runnners
-          cache-local-path: "/home/runner/_work/_tool/uv-local-cache"
-          prune-cache: false
-          python-version: ${{ vars.CI_PYTHON_VERSION || '3.10' }}
+          cache-local-path: "/home/runner/_work/_tool/uv-local-cache"  # Place cache in the tool dir because we mount this in our runnners
+          prune-cache: false                                           # We want to save all cache because it's in the mount^
+          python-version: ${{ vars.CI_PYTHON_VERSION || '3.11' }}      # Default to 3.11 where vars aren't available (PRs from forks)
       - name: Install dependencies
         run: |
           uv pip install -r requirements/requirements-dev.txt
diff --git a/.github/workflows/tests_integration.yml b/.github/workflows/tests_integration.yml
@@ -37,33 +37,13 @@ env:
   UV_LINK_MODE: "symlink"
 
 jobs:
-  changes:
-    name: Filter changed files
-    runs-on: mdb-dev
-    outputs:
-      not-docs: ${{ steps.filter.outputs.not-docs }}
-    steps:
-      - uses: actions/checkout@v4
-      - uses: dorny/paths-filter@v3
-        id: filter
-        with:
-          predicate-quantifier: "every"
-          filters: |
-            not-docs:
-              - '!docs/**'  
-              - '!**/*.md'
-              - '!.github/workflows/build_deploy_dev.yml'
-              - '!.github/workflows/test_on_deploy.yml'
-              - '!mindsdb/__about__.py'
   # Run our integration tests
   test:
-    needs: changes
     environment:
       name: ${{ inputs.deploy-env }}
       url: ${{ vars.MDB_ENV_URL }}
     name: Run integration tests on deploy
     runs-on: mdb-dev
-    if: ${{ github.ref_type == 'branch' && needs.changes.outputs.not-docs == 'true' }}
     steps:
     - uses: actions/checkout@v4
       with:
diff --git a/.github/workflows/tests_unit.yml b/.github/workflows/tests_unit.yml
@@ -25,56 +25,44 @@ jobs:
   code_checking:
     name: Run static code checks
     runs-on: mdb-dev
-    needs: changes
     steps:
       - name: Checkout
-        if: ${{ needs.changes.outputs.not-docs == 'true' }}
         uses: actions/checkout@v4
         with:
-          # required to grab the history of the PR for pre-commit to work out what's changed
-          fetch-depth: 0
-          ref: ${{ github.event.pull_request.head.sha }}  # Always check out the PR branch
-      # Install python and setup UV
+          fetch-depth: 0  # required to grab the history of the PR so pre-commit can work out what's changed
+          ref: ${{ github.event.pull_request.head.sha }}
       - name: Setup uv
-        if: ${{ needs.changes.outputs.not-docs == 'true' }}
         uses: astral-sh/setup-uv@v5
         with:
-          # Place cache in the tool dir because we mount this in our runnners
-          cache-local-path: "/home/runner/_work/_tool/uv-local-cache"
-          prune-cache: false
-          # I can't work out how to use vars.CI_PYTHON_VERSION for forks here in a nice way, so we have to hardcode it for forks
-          python-version: ${{ vars.CI_PYTHON_VERSION || '3.10' }}
+          cache-local-path: "/home/runner/_work/_tool/uv-local-cache"  # Place cache in the tool dir because we mount this in our runnners
+          prune-cache: false                                           # We want to save all cache because it's in the mount^
+          python-version: ${{ vars.CI_PYTHON_VERSION || '3.11' }}      # Default to 3.11 where vars aren't available (PRs from forks)
 
       # Checks the codebase for print() statements and fails if any are found
       # We should be using loggers instead
       - name: Check for print statements
-        if: ${{ needs.changes.outputs.not-docs == 'true' }}
         run: |
           # The pyproject file confuses uv: https://github.com/astral-sh/uv/issues/6838
           rm pyproject.toml
           uv run tests/scripts/check_print_statements.py
       
       - name: Install MDB dev requirements
-        if: ${{ needs.changes.outputs.not-docs == 'true' }}
         run: |
           uv pip install -r requirements/requirements-dev.txt
 
       # Run pre-commit on all changed files
       # See .pre-commit-config.yaml for the list of checks
       - name: Run pre-commit
-        if: ${{ needs.changes.outputs.not-docs == 'true' }}
         run: |
           pre-commit run --show-diff-on-failure --color=always --from-ref ${{ github.event.pull_request.base.sha || 'HEAD~1' }} --to-ref ${{ github.event.pull_request.head.sha || 'HEAD' }}
 
       # Runs a few different checks against our many requirements files
       # to make sure they're in order
       - name: Check requirements files
-        if: ${{ needs.changes.outputs.not-docs == 'true' }}
         run: |
           uv run tests/scripts/check_requirements.py
 
   # Creates a matrix of environments to test against using matrix_includes.json
-  # Used for installation checks below
   matrix_prep:
     name: Prepare matrix
     runs-on: mdb-dev
@@ -83,7 +71,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
         with:
-          ref: ${{ github.event.pull_request.head.sha }}  # Always check out the PR branch
+          ref: ${{ github.event.pull_request.head.sha }}
       - id: set-matrix
         uses: JoshuaTheMiller/conditional-build-matrix@v2.0.1
         with:
@@ -92,25 +80,21 @@ jobs:
   # Check that our pip package is able to be installed in all of our supported environments
   check_install:
     name: Check pip installation
-    needs: [changes, matrix_prep, code_checking]
+    needs: [matrix_prep, code_checking]
     strategy:
       matrix: ${{fromJson(needs.matrix_prep.outputs.matrix)}}
     runs-on: ${{ matrix.runs_on }}
     steps:
       - name: Checkout
-        if: ${{ needs.changes.outputs.not-docs == 'true' }}
         uses: actions/checkout@v4
         with:
-          ref: ${{ github.event.pull_request.head.sha }}  # Always check out the PR branch
-      # Install python and setup UV
+          ref: ${{ github.event.pull_request.head.sha }}
       - name: Setup uv
-        if: ${{ needs.changes.outputs.not-docs == 'true' }}
         uses: astral-sh/setup-uv@v5
         with:
           enable-cache: true
           python-version: ${{ matrix.python-version }}
       - name: Check pip package builds and installs
-        if: ${{ needs.changes.outputs.not-docs == 'true' }}
         run: |
           # Install dev requirements and build our pip package
           uv pip install -r requirements/requirements-dev.txt
@@ -123,31 +107,25 @@ jobs:
 
   unit_tests:
     name: Run Unit Tests
-    needs: [changes, matrix_prep, code_checking]
+    needs: [matrix_prep, code_checking]
     strategy:
       matrix: ${{fromJson(needs.matrix_prep.outputs.matrix)}}
     runs-on: ${{ matrix.runs_on }}
-    if: github.ref_type == 'branch'
     steps:
       - name: Checkout
-        if: ${{ needs.changes.outputs.not-docs == 'true' }}
         uses: actions/checkout@v4
         with:
-          ref: ${{ github.event.pull_request.head.sha }}  # Always check out the PR branch
-      # Install python and setup UV
+          ref: ${{ github.event.pull_request.head.sha }}
       - name: Setup uv
-        if: ${{ needs.changes.outputs.not-docs == 'true' }}
         uses: astral-sh/setup-uv@v5
         with:
           enable-cache: true
           python-version: ${{ matrix.python-version }}
-          version: "0.7.19"
       - name: Install dependencies
-        if: ${{ needs.changes.outputs.not-docs == 'true' }}
         run: |
-          uv pip install -r requirements/requirements-test.txt
           # TODO: for now some tests rely on lightwood
           uv pip install . \
+            -r requirements/requirements-test.txt \
             .[lightwood] \
             .[clickhouse] \
             .[snowflake] \
@@ -161,26 +139,11 @@ jobs:
             .[ms_teams] \
             .[salesforce] \
             .[mysql] \
-            .[chromadb]
+            .[chromadb] \
+            .[mssql]
           uv pip freeze
           git clone --branch v$(uv pip show mindsdb_sql_parser | grep Version | cut -d ' ' -f 2) https://github.com/mindsdb/mindsdb_sql_parser.git parser_tests
-      - name: Install mssql dependencies
-        if: ${{ needs.changes.outputs.not-docs == 'true' }}
-        run: |
-          # Set FreeTDS build flags only on macOS
-          # Currently broken due to new cython version, see https://github.com/pymssql/pymssql/issues/937
-          if [[ "$RUNNER_OS" == "macOS" ]]; then
-            echo "Skipping pymssql build on macOS temporarily"
-            # brew install freetds
-            # echo "Setting FreeTDS flags for macOS pymssql build"
-            # export LDFLAGS="-L$(brew --prefix freetds)/lib"
-            # export CFLAGS="-I$(brew --prefix freetds)/include"
-            # uv pip install pymssql==2.3.1 --no-binary :all:
-          else
-            uv pip install .[mssql]
-          fi
           
       - name: Run unit tests
-        if: ${{ needs.changes.outputs.not-docs == 'true' }}
         run: |
           make unit_tests_slow
