Skip to content

Commit c175d29

Browse files
authored
Shared pgvector: delete table for if kb is removed (#11987)
1 parent d8605ae commit c175d29

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

mindsdb/interfaces/knowledge_base/controller.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1237,7 +1237,7 @@ def add(
12371237
if vector_size is not None:
12381238
vector_db_params["vector_size"] = vector_size
12391239
vector_db_name = self._create_persistent_pgvector(vector_db_params)
1240-
1240+
params["default_vector_storage"] = vector_db_name
12411241
else:
12421242
# create chroma db with same name
12431243
vector_table_name = "default_collection"
@@ -1465,9 +1465,10 @@ def delete(self, name: str, project_name: int, if_exists: bool = False) -> None:
14651465
# drop objects if they were created automatically
14661466
if "default_vector_storage" in kb.params:
14671467
try:
1468-
handler = self.session.datahub.get(kb.params["default_vector_storage"]).integration_handler
1469-
handler.drop_table(kb.vector_database_table)
1470-
self.session.integration_controller.delete(kb.params["default_vector_storage"])
1468+
dn = self.session.datahub.get(kb.params["default_vector_storage"])
1469+
dn.integration_handler.drop_table(kb.vector_database_table)
1470+
if dn.ds_type != "pgvector":
1471+
self.session.integration_controller.delete(kb.params["default_vector_storage"])
14711472
except EntityNotExistsError:
14721473
pass
14731474
if "created_embedding_model" in kb.params:

0 commit comments

Comments
 (0)