added motherduck support in duckDB

[parthiv11]

Description

Please include a summary of the change and the issue it solves.

Fixes #10378

Type of change

(Please delete options that are not relevant)

• ⚡ New feature (non-breaking change which adds functionality)
• 📄 This change requires a documentation update

Verification Process

To ensure the changes are working as expected:

• Test Location: Specify the URL or path for testing.
• Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

• I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

• My code follows the style guidelines(PEP 8) of MindsDB.
• I have appropriately commented on my code, especially in complex areas.
• Necessary documentation updates are either made or tracked in issues.
• Relevant unit and integration tests are updated or added.

[martyna-mindsdb]

@parthiv11
Please resolve the conflicts so we can merge this.

[parthiv11]

Okay

…

On Thu, Jun 26, 2025, 6:58 PM martyna-mindsdb ***@***.***> wrote: *martyna-mindsdb* left a comment (mindsdb/minds-platform#10385) <#10385 (comment)> @parthiv11 <https://github.com/parthiv11> Please resolve the conflicts so we can merge this. — Reply to this email directly, view it on GitHub <#10385 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASBGDTDB7RALBGYSOFK7RQD3FPYRVAVCNFSM6AAAAABVPZTZH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMBYGUYDGOBXGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[parthiv11]

done @martyna-mindsdb

[martyna-mindsdb]

@parthiv11
Please address the issues in Tests on Push -- https://github.com/mindsdb/mindsdb/actions/runs/15928294634/job/44930902729?pr=10385
Thanks!

[martyna-mindsdb]

@parthiv11
Still some left -- https://github.com/mindsdb/mindsdb/actions/runs/15928841393/job/44933179817?pr=10385

[martyna-mindsdb]

@hamishfagg
Can you please approve this PR? It requires a manual approval.

[parthiv11]

@martyna-mindsdb @ZoranPandovski @MinuraPunchihewa

[entelligence-ai-pr-reviews]

Duplicate Code: ⚠️ Duplicate Code Detected (Similarity: 93%)

This function check_connection duplicates existing code.

📍 Original Location:

mindsdb/integrations/handlers/databend_handler/databend_handler.py:85-107

Function: check_connection

💡 Recommendation:
Implement a default check_connection() on the DatabaseHandler base class that follows this exact try/except/finally template, calling the subclass's connect(). Subclasses that need extra checks (e.g., SQLiteHandler's file existence guard) can override or call super().check_connection() and add pre-conditions. This would eliminate the boilerplate from every SQL handler.

Consider importing and reusing the existing function instead of duplicating the logic.

[entelligence-ai-pr-reviews]

Duplicate Code: ⚠️ Duplicate Code Detected (Similarity: 95%)

This function get_columns duplicates existing code.

📍 Original Location:

mindsdb/integrations/handlers/clickhouse_handler/clickhouse_handler.py:161-167

Function: get_columns

💡 Recommendation:
Consider a base-class or mixin get_columns() that issues a configurable describe query (e.g., a per-dialect template). For DuckDB and ClickHouse, the template is DESCRIBE {table_name}. Handlers that need extra column renaming (e.g., DatabendHandler renames Field→column_name) can override with a super() call followed by a rename step.

Consider importing and reusing the existing function instead of duplicating the logic.

[ea-rus]

@parthiv11, can you solve static code checks errors? Can you see a content of this error?

[parthiv11]

done @ea-rus

[entelligence-ai-pr-reviews]

Correctness: The motherduck_token is embedded directly in the database connection string as a URL query parameter (?motherduck_token=...), which means it will appear in plaintext in logs, error messages (e.g., the check_connection error log includes the database string), and any tracing/debugging output. This leaks a sensitive credential.

🤖 AI Agent Prompt for Cursor/Windsurf

📋 Copy this prompt to your AI coding assistant (Cursor, Windsurf, etc.) to get help fixing this issue

In mindsdb/integrations/handlers/duckdb_handler/duckdb_handler.py, lines 47-50, the motherduck_token is embedded in the database connection string URL. This causes the token to appear in log output (e.g., check_connection logs `self.connection_data['database']` on error, and native_query logs it too). Consider passing the token via the duckdb `config` parameter (e.g., `duckdb.connect(database='md:dbname', config={'motherduck_token': token})`) instead of embedding it in the URL, to avoid credential exposure in logs and error messages.