Fix for undetectable encodings (#10884)#10905
Merged
ea-rus merged 14 commits intoNov 28, 2025
Merged
Conversation
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
|
@hamishfagg |
Contributor
|
@trickster026 |
Contributor
|
@ZoranPandovski |
Contributor
Author
|
Any update on merging this PR @martyna-mindsdb? |
ZoranPandovski
previously approved these changes
Nov 10, 2025
ZoranPandovski
requested changes
Nov 10, 2025
Member
ZoranPandovski
left a comment
There was a problem hiding this comment.
Hey @trickster026 , thanks this is ready to be merged but you need to point to develop instead of main branch. Can you please do that?
ea-rus
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where the email handler would fail when processing emails with undetectable character encodings. The error occurred when
chardet.detect()returnedNonefor the encoding, causing aNoneTypeerror.Fixes #10884
Type of change
Verification Process
To ensure the changes are working as expected:
pytest tests/unused/unit/handler_tests/test_email_handler.py::TestEmailHandler::test_undetectable_encoding_handling -vChecklist: