Faiss handler with flat index#11839
Merged
Merged
Conversation
# Conflicts: # mindsdb/integrations/handlers/statsforecast_handler/requirements.txt # mindsdb/integrations/handlers/statsforecast_handler/requirements_extra.txt
…nstead of serving it locally (#11895)
Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Continue of #11750
Query examples:
Keyword search
Implemented by using duckdb fts extension
How it works: when keyword search is used and FTS index doesn't exist - it is created
But this index is removed when any record is inserted into KB (because FTS index isn't updated after inserts in duckdb)
Other updates:
User request is kept sync (user waits till insert is completed)
Fixes https://linear.app/mindsdb/issue/FQE-1830/faiss-handler-v1-flat-index-kw-search
Type of change
Verification Process
To ensure the changes are working as expected:
Additional Media:
Checklist: