Skip to content

[Bug]: README's for integrations are statically pulled from GitHub, instead of serving it locally#11895

Merged
setohe0909 merged 3 commits into
releases/v26.0.0from
FQE-1444
Nov 18, 2025
Merged

[Bug]: README's for integrations are statically pulled from GitHub, instead of serving it locally#11895
setohe0909 merged 3 commits into
releases/v26.0.0from
FQE-1444

Conversation

@setohe0909
Copy link
Copy Markdown
Contributor

@setohe0909 setohe0909 commented Nov 17, 2025

Description

FE PR --> https://github.com/mindsdb/mindsdb-frontend/pull/3293

Fixes FQE-1444

Type of change

  • ⚡ New feature (non-breaking change which adds functionality)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@setohe0909 setohe0909 self-assigned this Nov 17, 2025
@setohe0909 setohe0909 changed the base branch from main to releases/v26.0.0 November 17, 2025 02:42
@entelligence-ai-pr-reviews
Copy link
Copy Markdown
Contributor

🔒 Entelligence AI Vulnerability Scanner

No security vulnerabilities found!

Your code passed our comprehensive security analysis.

📊 Files Analyzed: 1 files


@entelligence-ai-pr-reviews
Copy link
Copy Markdown
Contributor

Review Summary

🏷️ Draft Comments (1)

Skipped posting 1 draft comments that were valid but scored below your review threshold (>=13/15). Feel free to update them here.

mindsdb/api/http/namespaces/handlers.py (1)

113-114: The HandlerReadme.get method reads the entire README.md file into memory without caching, causing repeated disk I/O and latency for frequent requests.

📊 Impact Scores:

  • Production Impact: 2/5
  • Fix Specificity: 2/5
  • Urgency Impact: 2/5
  • Total Score: 6/15

🤖 AI Agent Prompt (Copy & Paste Ready):

In mindsdb/api/http/namespaces/handlers.py, lines 113-114, the HandlerReadme.get method reads README.md from disk on every request, causing unnecessary disk I/O and latency for repeated requests. Add a simple in-memory cache (e.g., as a class attribute) to store the README content per handler, so repeated requests serve from memory instead of disk. Preserve thread safety if needed.

Comment thread mindsdb/api/http/namespaces/handlers.py Outdated
@setohe0909 setohe0909 requested a review from StpMax November 17, 2025 23:01
@entelligence-ai-pr-reviews
Copy link
Copy Markdown
Contributor

Review Summary

🏷️ Draft Comments (1)

Skipped posting 1 draft comments that were valid but scored below your review threshold (>=13/15). Feel free to update them here.

mindsdb/api/http/namespaces/handlers.py (1)

77-80: HandlerInfo.get does not check if handler_meta is None before using it, which will cause a crash if the handler does not exist.

📊 Impact Scores:

  • Production Impact: 4/5
  • Fix Specificity: 5/5
  • Urgency Impact: 3/5
  • Total Score: 12/15

🤖 AI Agent Prompt (Copy & Paste Ready):

In mindsdb/api/http/namespaces/handlers.py, lines 77-80, the function HandlerInfo.get does not check if handler_meta is None before using it, which will cause a crash if the handler does not exist. Add a check for handler_meta is None and return an appropriate error response if so.

@setohe0909 setohe0909 merged commit ad528c3 into releases/v26.0.0 Nov 18, 2025
4 checks passed
@setohe0909 setohe0909 deleted the FQE-1444 branch November 18, 2025 16:36
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants