Skip to content

KB max batch size: apply insert limit globally #11905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ea-rus merged 2 commits into from
Nov 19, 2025
Merged

KB max batch size: apply insert limit globally #11905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96f35a8
apply insert limit globally
ea-rus Nov 18, 2025
35c7375
Merge branch 'releases/25.11.0' into max-insert-batch
ea-rus Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mindsdb/interfaces/agents/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@
USER_COLUMN = "question"
DEFAULT_EMBEDDINGS_MODEL_PROVIDER = "openai"
DEFAULT_EMBEDDINGS_MODEL_CLASS = OpenAIEmbeddings
MAX_INSERT_BATCH_SIZE = 50_000
MAX_INSERT_BATCH_SIZE = int(os.getenv("KB_MAX_INSERT_BATCH_SIZE", 50_000))
DEFAULT_TIKTOKEN_MODEL_NAME = os.getenv("DEFAULT_TIKTOKEN_MODEL_NAME", "gpt-4")
AGENT_CHUNK_POLLING_INTERVAL_SECONDS = os.getenv("AGENT_CHUNK_POLLING_INTERVAL_SECONDS", 1.0)
DEFAULT_TEXT2SQL_DATABASE = "mindsdb"
Expand Down
5 changes: 3 additions & 2 deletions mindsdb/interfaces/knowledge_base/controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,8 +586,6 @@ def insert_rows(self, rows: List[Dict]):
"""Process and insert raw data rows"""
if not rows:
return
if len(rows) > MAX_INSERT_BATCH_SIZE:
raise ValueError("Input data is too large, please load data in batches")

df = pd.DataFrame(rows)

Expand Down Expand Up @@ -700,6 +698,9 @@ def insert(self, df: pd.DataFrame, params: dict = None):
if df.empty:
return

if len(df) > MAX_INSERT_BATCH_SIZE:
raise ValueError("Input data is too large, please load data in batches")

try:
run_query_id = ctx.run_query_id
# Link current KB to running query (where KB is used to insert data)
Expand Down
Loading