Skip to content

test: salvage, migrate, and fix unused unit and integration tests#12299

Closed
sejubar wants to merge 4 commits into
releases/26.1.0from
FQE-1952-clean-up-unit-test-v1
Closed

test: salvage, migrate, and fix unused unit and integration tests#12299
sejubar wants to merge 4 commits into
releases/26.1.0from
FQE-1952-clean-up-unit-test-v1

Conversation

@sejubar
Copy link
Copy Markdown
Contributor

@sejubar sejubar commented Mar 17, 2026

Description

Revive/remove unused tests and clean up unit test excluding knowledge base tests

Fixes #issue_number

Type of change

(Please delete options that are not relevant)

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ⚡ New feature (non-breaking change which adds functionality)
  • 📢 Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • 📄 This change requires a documentation update

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@entelligence-ai-pr-reviews
Copy link
Copy Markdown
Contributor

Automatic Review Skipped

Too many files for automatic review.

If you would still like a review, you can trigger one manually by commenting:

@entelligence review

@martyna-mindsdb martyna-mindsdb requested a review from ea-rus March 18, 2026 14:49
Comment thread tests/unused/load/tasks.py Outdated
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZoranPandovski, should be 'load' folder be kept? or moved to other repo if it has something useful?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be reworked in separated pr, it covers resp api tests
I will create an issue for it

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe move all tests from ‎tests/unused/unit/handler_tests and tests/unused/unit/ml_handlers/ to handler folders? for example this one into mindsdb/integrations/handlers/apache_doris_handler/tests/
if we don't want to run them we can keep their code at least

@ea-rus ea-rus mentioned this pull request Mar 31, 2026
@sejubar sejubar requested a review from a team as a code owner April 13, 2026 12:49
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 13, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sejubar
Copy link
Copy Markdown
Contributor Author

sejubar commented Apr 13, 2026

signed and agreed to the CLA

@sejubar sejubar force-pushed the FQE-1952-clean-up-unit-test-v1 branch from 7fb04c3 to f9d79ae Compare April 13, 2026 14:26
@sejubar sejubar closed this Apr 15, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants