Merge pull request #220 from mindsdb/del-kb-completions-endpoint

Delete POST `knowledge_bases/<name>/completions` endpoint

Author: StpMax

mindsdb_sdk/connectors/rest_api.py

@@ -424,14 +424,6 @@ def create_knowledge_base(self, project: str, data):
 
         return r.json()
 
-    def knowledge_base_completion(self, project: str, knowledge_base_name, payload):
-        r = self.session.post(
-            self.url + f'/api/projects/{project}/knowledge_bases/{knowledge_base_name}/completions',
-            json=payload
-        )
-        _raise_for_status(r)
-        return r.json()
-    
     def get_config(self):
         """
         Get MindsDB configuration.

mindsdb_sdk/knowledge_bases.py

@@ -246,11 +246,6 @@ def insert_query(self, data: Query, params: dict = None):
             data=data
         )
 
-    def completion(self, query, **data):
-        data['query'] = query
-
-        return self.api.knowledge_base_completion(self.project.name, self.name, data)
-
 
 class KnowledgeBases(CollectionBase):
     """

tests/test_sdk.py

@@ -1301,16 +1301,6 @@ def check_project_kb(self, project, database, mock_get, mock_del, mock_post, moc
             },
         }}}
 
-        # completion
-        kb.completion('hi', type='chat', llm_model='gpt-4')
-        args, kwargs = mock_post.call_args
-        assert args[0] == f'{DEFAULT_CLOUD_API_URL}/api/projects/{project.name}/knowledge_bases/{kb.name}/completions'
-        assert kwargs == {'json': {
-            'query': 'hi',
-            'type': 'chat',
-            'llm_model': 'gpt-4',
-        }}
-
         # drop
         project.knowledge_bases.drop('kb2')