Added Chase the Skies game drop and fixed some compatiblity issue with some node/typescript version#18
Conversation
henriquecolini
left a comment
There was a problem hiding this comment.
Hey, thanks for the contribution!
Can you please elaborate on why exactly you created the "type" directory and moved some files in there? Not only do I not see why that is necessary, I also prefer the previous folder structure, it was cleaner and less ambiguous (those files do not contain types).
Also, can you explain why did you replace "noEmit" with "emitDeclarationOnly" in tsconfig? I don't need declaration files in the bundled output.
Additionally, I'd like you to undo the change where you deleted bedrock/version_vibrant_visuals.png and used the java icon instead for the Bedrock Vibrant Visuals update. I purposefully keep all edition files 100% independent of each other (even if the image is the same), because that is much easier to maintain and navigate about.
I think the easiest thing to do is just revert these all changes, keeping just the renamed bedrock/version_1_21_90.png and editions.ts.
|
Considering it's already been a few weeks since these updates (and java 1.21.7 is already on the horizon), I'd kindly ask you to fix these problems in the next couple days or so; otherwise I'll sadly need to close this PR and do these changes myself. |
|
Hi, i'll work on it tomorrow if i have time. I can show the error i got when i tried to run the project without editing the tsconfig or moving some files into another folder. Maybe it's because we don't have the same nodejs version ? If you can tell me which version you're using i'll try with it to see if i still have this error I'll add the 1.21.7 and the freshly announced new game drop as well |
|
No need to add 1.21.7 and the new game drop. Just fix the changes you made; I can add these new updates as they require new icons :) |
|
I've just reverted the changes made to the file structure and tsconfig With the original config i got this error in my browser's console: I'm using node 23 if that helps |
henriquecolini
left a comment
There was a problem hiding this comment.
Yeah, looks good to me now. I'll add the upcoming updates now and take a look at that error later.
I also merge the Vibrant visuals and the Chase the Skies on Bedrock edition since they both came in 1.26.90