fix: simplify testRemoveObjects and use Exception in removeObjects

Address review feedback on PR #1700:
- Use Exception instead of IOException in removeObjects() helper
  for consistency with the rest of the test class.
- Remove the finally/succeeded retry in testRemoveObjects() now that
  removeObjects() retries transient failures internally; drops the
  associated DE_MIGHT_IGNORE SpotBugs suppression.

Author: allanrogerr

functional/TestMinioClient.java

@@ -113,7 +113,6 @@
 import io.minio.messages.Tags;
 import io.minio.messages.VersioningConfiguration;
 import java.io.ByteArrayInputStream;
-import java.io.IOException;
 import java.io.InputStream;
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
@@ -1059,7 +1058,7 @@ public void removeObjects(String bucketName, List<ObjectWriteResponse> results)
         DeleteResult.Error err = r.get();
         String code = err.code();
         if (!TRANSIENT_DELETE_CODES.contains(code)) {
-          throw new IOException(
+          throw new Exception(
               "non-transient delete error '"
                   + code
                   + "': "
@@ -1074,7 +1073,7 @@ public void removeObjects(String bucketName, List<ObjectWriteResponse> results)
       if (!anyTransient) break;
     }
     if (anyTransient) {
-      throw new IOException(
+      throw new Exception(
           results.size()
               + " object(s) not deleted after "
               + MAX_DELETE_ATTEMPTS
@@ -1223,29 +1222,15 @@ public void removeObject() throws Exception {
         RemoveObjectArgs.builder().bucket(bucketName).object(getRandomName()).build());
   }
 
-  @edu.umd.cs.findbugs.annotations.SuppressFBWarnings(
-      value = "DE_MIGHT_IGNORE",
-      justification =
-          "Cleanup exception suppressed intentionally so original test failure propagates")
   public void testRemoveObjects(String testTags, List<ObjectWriteResponse> results)
       throws Exception {
     String methodName = "removeObjects()";
     long startTime = System.currentTimeMillis();
-    boolean succeeded = false;
     try {
       removeObjects(bucketName, results);
       mintSuccessLog(methodName, testTags, startTime);
-      succeeded = true;
     } catch (Exception e) {
       handleException(methodName, testTags, startTime, e);
-    } finally {
-      if (!succeeded) {
-        try {
-          removeObjects(bucketName, results);
-        } catch (Exception ignored) {
-          // suppress so the original test exception propagates unmasked
-        }
-      }
     }
   }