Skip to content

fix CORS configuration comparison #1707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balamurugana merged 1 commit into from
Jun 12, 2026
+12 −5
Merged

fix CORS configuration comparison #1707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions functional/TestArgs.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ public TestArgs(String endpoint, String accessKey, String secretKey, String regi
String kmsKeyName = "my-minio-key";
if (endpoint == null) {
this.endpoint = "http://localhost:9000";
this.endpointTLS = "https://localhost:9001";
this.endpointTLS = "https://localhost:10000";
this.accessKey = "minio";
this.secretKey = "minio123";
this.region = "us-east-1";
Expand Down Expand Up @@ -345,7 +345,7 @@ public static void handleException(String methodName, String args, long startTim
}

public static boolean downloadMinioServer() throws IOException {
String url = "https://dl.min.io/server/minio/release/";
String url = "https://dl.min.io/aistor/minio/release/";
if (OS.contains("linux")) {
url += "linux-amd64/minio";
} else if (OS.contains("windows")) {
Expand Down Expand Up @@ -388,13 +388,17 @@ public static Process runMinioServer(boolean tls) throws Exception {
new ProcessBuilder(
binaryPath.getPath(),
"server",
"--license",
"minio.license",
"--address",
":9001",
":10000",
"--certs-dir",
".cfg/certs",
".d{1...4}");
} else {
pb = new ProcessBuilder(binaryPath.getPath(), "server", ".d{1...4}");
pb =
new ProcessBuilder(
binaryPath.getPath(), "server", "--license", "minio.license", ".d{1...4}");
}

Map<String, String> env = pb.environment();
Expand Down
4 changes: 3 additions & 1 deletion functional/TestMinioClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2969,7 +2969,9 @@ public void testBucketCors(String methodName, boolean getTest, boolean deleteTes
CORSConfiguration config =
client.getBucketCors(GetBucketCorsArgs.builder().bucket(bucketName).build());
Assertions.assertEquals(
expectedConfig, config, "cors: expected: " + expectedConfig + ", got: " + config);
expectedConfig.toString(),
config.toString(),
"cors: expected: " + expectedConfig.toString() + ", got: " + config.toString());
}
if (deleteTest) {
client.deleteBucketCors(DeleteBucketCorsArgs.builder().bucket(bucketName).build());
Expand Down
1 change: 1 addition & 0 deletions functional/minio.license
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
eyJhbGciOiJFUzM4NCIsInR5cCI6IkpXVCJ9.eyJhaWQiOjAsImNhcCI6MCwiaWF0IjoxLjc4MDAzMTY0NTUyMzA5ODM1OGU5LCJpc3MiOiJzdWJuZXRAbWluLmlvIiwibGlkIjoiYjNhYTliNGQtOTUxYy00MjIzLTgyMmEtZGY2NjE5MDNjOWFkIiwibm9kZXMiOjEsIm9yZyI6IiIsInBsYW4iOiJGUkVFIiwicHJvZHVjdCI6IkFJU3RvciIsInN1YiI6ImRldkBtaW5pby5pbyIsInRyaWFsIjpmYWxzZX0.Aq0kaFgd5SMHYEK7fIYzPsU4xlS119sj-BSyftCDpmtHIbW6KNFXGA9nbKPc17ZXKgcQgUoaPncsq30EOy7PyH-lp3LPpy3rPoD7ptJHI2v0jqpvlnP0cVGK0Yuw3vib
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Comment thread
rraulinio marked this conversation as resolved.
Loading