Skip to content

Commit 3c41001

Browse files
committed
Clean the implementation of header assertions
1 parent 764ad35 commit 3c41001

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

src/WebAssert.php

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -188,11 +188,9 @@ public function responseHeaderNotEquals($name, $value)
188188
public function responseHeaderContains($name, $value)
189189
{
190190
$actual = $this->session->getResponseHeader($name);
191-
$actual = preg_replace('/\s+/u', ' ', $actual);
192-
$regex = '/'.preg_quote($value, '/').'/ui';
193191
$message = sprintf('The text "%s" was not found anywhere in the "%s" response header.', $value, $name);
194192

195-
$this->assert((bool) preg_match($regex, $actual), $message);
193+
$this->assert(false !== stripos($actual, $value), $message);
196194
}
197195

198196
/**
@@ -206,11 +204,9 @@ public function responseHeaderContains($name, $value)
206204
public function responseHeaderNotContains($name, $value)
207205
{
208206
$actual = $this->session->getResponseHeader($name);
209-
$actual = preg_replace('/\s+/u', ' ', $actual);
210-
$regex = '/'.preg_quote($value, '/').'/ui';
211207
$message = sprintf('The text "%s" was found in the "%s" response header, but it should not.', $value, $name);
212208

213-
$this->assert(!preg_match($regex, $actual), $message);
209+
$this->assert(false === stripos($actual, $value), $message);
214210
}
215211

216212
/**

0 commit comments

Comments
 (0)