Merge pull request #69 from stof/deprecate_url_alteration

Deprecated the URL alteration in visit()

Author: stof

src/Behat/Mink/Driver/BrowserKitDriver.php

@@ -45,7 +45,7 @@ class BrowserKitDriver extends CoreDriver
     private $forms = array();
     private $serverParameters = array();
     private $started = false;
-    private $removeScriptFromUrl = true;
+    private $removeScriptFromUrl = false;
     private $removeHostFromUrl = false;
 
     /**
@@ -86,19 +86,31 @@ public function setSession(Session $session)
      * Tells driver to remove hostname from URL.
      *
      * @param Boolean $remove
+     *
+     * @deprecated Deprecated as of 1.2, to be removed in 2.0. Pass the base url in the constructor instead.
      */
     public function setRemoveHostFromUrl($remove = true)
     {
+        trigger_error(
+            'setRemoveHostFromUrl() is deprecated as of 1.2 and will be removed in 2.0. Pass the base url in the constructor instead.',
+            E_USER_DEPRECATED
+        );
         $this->removeHostFromUrl = (bool) $remove;
     }
 
     /**
      * Tells driver to remove script name from URL.
      *
      * @param Boolean $remove
+     *
+     * @deprecated Deprecated as of 1.2, to be removed in 2.0. Pass the base url in the constructor instead.
      */
     public function setRemoveScriptFromUrl($remove = true)
     {
+        trigger_error(
+            'setRemoveScriptFromUrl() is deprecated as of 1.2 and will be removed in 2.0. Pass the base url in the constructor instead.',
+            E_USER_DEPRECATED
+        );
         $this->removeScriptFromUrl = (bool) $remove;
     }
 

tests/Behat/Mink/Driver/BrowserKitDriverTest.php

@@ -15,7 +15,6 @@ protected static function getDriver()
     {
         $client = new Client(require(__DIR__.'/../../../app.php'));
         $driver = new BrowserKitDriver($client);
-        $driver->setRemoveScriptFromUrl(false);
 
         return $driver;
     }