Skip to content

Commit b0909b6

Browse files
committed
Changed the default value of removeScriptFromUrl to false
This is a much more sensible default, as highlighted by the fact that it was needed for the testsuite. This is now applied even without a base url.
1 parent c467d2e commit b0909b6

2 files changed

Lines changed: 1 addition & 3 deletions

File tree

src/Behat/Mink/Driver/BrowserKitDriver.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ class BrowserKitDriver extends CoreDriver
4545
private $forms = array();
4646
private $serverParameters = array();
4747
private $started = false;
48-
private $removeScriptFromUrl = true;
48+
private $removeScriptFromUrl = false;
4949
private $removeHostFromUrl = false;
5050

5151
/**
@@ -61,7 +61,6 @@ public function __construct(Client $client, $baseUrl = null)
6161

6262
if ($baseUrl !== null && $client instanceof HttpKernelClient) {
6363
$client->setServerParameter('SCRIPT_FILENAME', parse_url($baseUrl, PHP_URL_PATH));
64-
$this->removeScriptFromUrl = false;
6564
}
6665
}
6766

tests/Behat/Mink/Driver/BrowserKitDriverTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ protected static function getDriver()
1515
{
1616
$client = new Client(require(__DIR__.'/../../../app.php'));
1717
$driver = new BrowserKitDriver($client);
18-
$driver->setRemoveScriptFromUrl(false);
1918

2019
return $driver;
2120
}

0 commit comments

Comments
 (0)